Repository navigation
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Desktop loops are workflows with origin_product "loops". Counting them would star Workflows and Broadcasts for people who never opened either, and inflate the Workflows created step with another product's traffic. The error-tracking test now asserts the captured error instead of a row that a mocked register can never write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silthus
force-pushed
the
workflows-tracking/creation-intent
branch
from
October 20, 2026 11:18
87c1e09 to
d02dc41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
workflowsproduct intent counts clicks on "New workflow", not saved workflows.Impact
Pays into Grow Workflows through the "Created" step of the Workflows activation funnel (measured here). Expected move: small, toward accuracy. Abandoned clicks stop counting, and creates from templates, AI, MCP and the API start counting.
Merge Danger
Note
🔵 Merge risk: low · two-way door (merge-risk rubric)
Changes
workflowsintent (workflow_created), whatever channel created it.HogFlowViewSet.perform_createcallsProductIntent.registerright after the save, before activity logging.origin_product: "loops", owned by another product. Counting it would star Workflows and Broadcasts in the sidebar of someone who never opened either.addProductIntentcall, in both the Lemon and the Quill variant. It still sets the type filter and opens the template chooser. Nothing looks different.Related: #115349 emits the team analytics event
workflows workflow createdfrom the model for a different consumer, product analytics. #119330 adds AI consent to the product intent event insideProductIntent.register. None of the three share files, so they merge in any order.Recreates the intent part of Silthus/posthog#357, originally #111267 (closed).
How did you test this code?
Test rationale: extends the create endpoint tests next to the existing activity-log test. The test seam is the public
POST /api/projects/:id/hog_flowsendpoint.capture_exceptionis removed.Ran locally on the current head, rebased onto current
master:All of
test_hog_flow.py: 526 passed.Frontend
tsgo(no errors),oxlintandoxfmton the touched file,ruff check,ruff format --checkandty checkon the touched Python files.Live run against a local Django server and a migrated scratch database, through the API with a personal API key:
workflowsintent contextsregistercall the click endpoint makesx-posthog-client: mcporigin_product: "loops"Every create returned 201 and logged no error.
Gaps:
workflowsintent, and how many creates are loops) is not measured yet. Read access starts 2026-11-02.masterafter this PR opened: transactional email workflows and accepted data suggestion drafts. They register no intent. This PR keeps its scope to the create endpoint.Release status
Docs update
None. No existing doc covers Workflows product intents.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: T3 Code with Claude Code, Claude Opus 5.5 (
claude-opus-5-5). An earlier Codex worker (GPT-6.1 Sol) moved the intent server-side before its session dropped.Involvement: no grilling rounds, no prototypes. Reviews: a pre-rebase read-only Claude review and Codex review, then a QA swarm round on the rebased head (GPT-6.1 Sol on correctness, risk, design and the author's perspective; Claude Opus 5.5 fresh eyes). Live-run proof captured.
masteron 2026-10-20.masterhad moved the button's click handler intoonNewWorkflowfor the Quill title actions, so the intent call came out of that handler instead.tdd,writing-tests,improving-drf-endpoints,writing-pr-descriptions,writing-voice.ProductIntentmodel documents as a known caveat andmasteralready reaches.