Skip to content

chore(ci): use the published resolve-release action - #105062

Merged
trunk-io[bot] merged 1 commit into
masterfrom
chore/use-published-resolve-release-action
Sep 23, 2026
Merged

trunk-io[bot] merged 1 commit into
masterfrom
chore/use-published-resolve-release-action

Conversation

@ablaszkiewicz

@ablaszkiewicz ablaszkiewicz commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Changes

  • Both image builds call PostHog/resolve-release, pinned to the v1.0.0 commit SHA. The image still gets POSTHOG_RELEASE_ID, so deploys see no difference.
  • The in-repo composite action and its Depot mirror are deleted.
  • Both steps pass project-id: '2' and release-name: posthog explicitly. The deleted action defaulted to them, and the Dockerfile sourcemap stage looks up the release by the same name and version.
  • A download, checksum, or API error now fails the step instead of only warning. The step-level continue-on-error still keeps the build going with an empty id.
  • A missing secret still gives an empty id and a warning, and the step passes.
  • The action pins CLI 0.18.3 with a checksum-verified installer. The Dockerfile keeps its own 0.18.2 pin, because both sides find the release by name and version.

Note

Not verified: whether Depot CI sets GITHUB_ACTION_PATH for a remote composite action. The action needs it to find its script. If it is unset, the outage image ships without the id, which continue-on-error covers. Depot CI already runs a remote action here (PostHog/posthog-github-action in .depot/workflows/ci-backend.yml), but that one is a Node action.

How did you test this code?

  • The action's own test run covers the empty-key path on Linux and macOS runners.
  • PostHog/resolve-release@v1 ran end to end in a private test repository on GitHub Actions. It created a release, the Docker image carried its id, and a Python app sent an event and an $exception with that $release_id.
  • Not run: this workflow and the outage build. Both run only on master pushes or manual dispatch. The first master push after merge shows the resolved id, or the step error, in the job log.

Automatic notifications

  • Publish to changelog?

Docs update

None. No doc under docs/ describes the release step.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5

🤖 Generated with Claude Code

@ablaszkiewicz ablaszkiewicz self-assigned this Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI report

🚨 Trunk lane — universal lane

This PR is assigned to the universal lane. It cannot merge in parallel with other PRs, so it can take longer to merge. Ask dev-ex if you think this is wrong.

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Retrigger

The PR appears safe to merge with no actionable defect established in the changed workflows.

Reviews (1) · Last reviewed commit: "chore(ci): use the published resolve-rel..."

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: c06784aa-25ce-4d65-a69d-3a62d33fc946

📥 Commits

Reviewing files that changed from the base of the PR and between c10d68f and 61e7291.

📒 Files selected for processing (4)
  • .depot/actions/resolve-error-tracking-release/action.yml
  • .depot/workflows/actions-outage-image-build.yml
  • .github/actions/resolve-error-tracking-release/action.yml
  • .github/workflows/container-images-cd.yml
💤 Files with no reviewable changes (2)
  • .depot/actions/resolve-error-tracking-release/action.yml
  • .github/actions/resolve-error-tracking-release/action.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Both image workflows now use the pinned PostHog/resolve-release action. The outage image workflow omits the release version; the container image workflow retains its SHA-based release version. Both repository-local composite action definitions were removed.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 61e72

The image builds retain release resolution, with no identified regression that needs to be fixed before merging.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description is complete and stand-alone. It explains the problem, changes, testing status, documentation status, and agent context. It does not include the required before-and-after Mermaid flowch…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@ablaszkiewicz
ablaszkiewicz marked this pull request as ready for review September 23, 2026 10:57
@ablaszkiewicz
ablaszkiewicz requested review from hpouillot and a lite review from Copilot September 23, 2026 10:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team September 23, 2026 10:57
Base automatically changed from feat/django-release-id to master September 23, 2026 11:01
@trunk-io

trunk-io Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

😎 Stack merged successfully - details.

@ablaszkiewicz
ablaszkiewicz force-pushed the chore/use-published-resolve-release-action branch from 61e7291 to 65f5cb2 Compare September 23, 2026 11:13
Replace the in-repo resolve-error-tracking-release composite action and its
Depot mirror with PostHog/resolve-release, pinned to v1.0.0.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ablaszkiewicz
ablaszkiewicz force-pushed the chore/use-published-resolve-release-action branch from 65f5cb2 to 5eccd47 Compare September 23, 2026 11:31
@trunk-io
trunk-io Bot merged commit 3c3b6ea into master Sep 23, 2026
215 checks passed
@trunk-io
trunk-io Bot deleted the chore/use-published-resolve-release-action branch September 23, 2026 11:59
@deployment-status-posthog

deployment-status-posthog Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-09-23 12:42 UTC Run
prod-us ✅ Deployed 2026-09-23 12:53 UTC Run
prod-eu ✅ Deployed 2026-09-23 12:55 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants