Repository navigation
chore: bump quinn-proto (Dependabot #1) and lint tests with clippy - #311
Merged
Merged
Conversation
Clears Dependabot alert 1 (quinn-proto 0.11.14). Lockfile-only: quinn-proto is only reachable through reqwest's unstable http3 path, so no shipped feature compiles it. The bump also drops rand 0.9 and zerocopy from the lockfile in favour of rand_pcg 0.10. Tested: cargo test --features mcp,tower (all pass).
CI's clippy steps omitted --tests, so test code had drifted:
- httpmock 0.8 deprecations: matches -> is_true, assert_hits ->
assert_calls, hits -> calls (same signatures).
- test_on_error used the deprecated personal_api_key; now secret_key.
- tests/common: type alias for the complex return type, allow
dead_code on default_user_agent (not every test crate uses it).
- minimal_gate_test_support had #![cfg(test)] duplicating the
#[cfg(test)] on its mod declaration.
- error_tracking test: crate is edition 2018, so "{name:?}" in an
assert! message was printed literally; pass the arg explicitly.
- ci.yaml: add --tests to both clippy steps.
Tested: cargo clippy --lib --tests --features mcp,tower -D warnings,
cargo clippy --tests [--features mcp] -D warnings, cargo fmt --check:
clean. cargo test --features mcp,tower and
cargo test --no-default-features --features capture-v1: all pass.
Contributor
posthog-rs-v0 Compliance ReportDate: 2026-10-27 13:06:21 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
posthog-rs-v1 Compliance ReportDate: 2026-10-27 13:07:27 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
0.11.19 depends on rand 0.10, whose edition2024 manifest Cargo 1.78 cannot parse, so the MSRV jobs failed with --locked even though quinn is never compiled. 0.11.15 is the advisory's first patched version and still uses rand 0.9, so the lockfile diff vs main is now one line. Tested: cargo +1.78.0 check --locked --lib --features capture-v1 and --no-default-features --features error-tracking,capture-v1; cargo +1.88.0 check --locked --lib --features mcp; clippy --tests (default, mcp, mcp+tower) -D warnings; cargo test --features mcp,tower: all pass.
marandaneto
approved these changes
Oct 27, 2026
marandaneto
left a comment
marandaneto
left a comment
Member
There was a problem hiding this comment.
The code looks good; no qualifying findings. Verdict: correct.
lucasheriques
added a commit
that referenced
this pull request
Oct 27, 2026
The crate is on edition 2018, where an assert! message with no arguments is not a format string, so these six messages printed their {placeholders} literally on failure. Found by main's new clippy --tests step after merging #311.
Tested: cargo clippy --tests (default and --features mcp,tower) clean; cargo test --features mcp,tower 507 passed, default 387 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Two small housekeeping fixes found while working on the Rust MCP analytics SDK:
quinn-proto0.11.14 -> 0.11.15 (the advisory's first patched version). One-line lockfile change. quinn-proto is reachable only through reqwest's unstable http3 path, so no shipped feature compiles it. Pinned to 0.11.15 rather than the latest 0.11.19 because 0.11.19 depends on rand 0.10, whose edition2024 manifest Cargo 1.78 cannot parse, which breaks the--lockedMSRV jobs even though quinn is never compiled.--tests, so test code had drifted. Fixed:matches->is_true,assert_hits[_async]->assert_calls[_async],hits->calls.tests/test_on_error.rsused the deprecatedpersonal_api_key; nowsecret_key.tests/common/mod.rs: type alias for the complex return type;#[allow(dead_code)]ondefault_user_agent, matchingcapture_error_sink, since not every test crate uses it.src/client/minimal_gate_test_support.rs: inner#![cfg(test)]duplicated the#[cfg(test)]on itsmoddeclaration (the siblinglocal_payload_test_supportalready omits it).src/error_tracking.rstest: the crate is edition 2018, so"should strip {name:?}"in anassert!was printed literally. The argument is now passed explicitly..github/workflows/ci.yaml: both clippy steps now pass--testsso this stays clean. This touches.github/, so a maintainer with workflow rights (Lucas) needs to merge.No changeset: no published code or behaviour changes.
💚 How did you test it?
cargo clippy --lib --tests --features mcp,tower -- -D warnings: cleancargo clippy --tests -- -D warningsandcargo clippy --tests --features mcp -- -D warnings(the new CI steps): cleancargo +1.78.0 check --locked(both MSRV variants) andcargo +1.88.0 check --locked --features mcp: passcargo fmt -- --check: cleancargo test --features mcp,tower: all passcargo test --no-default-features --features capture-v1: all passCargo.lockno longer contains quinn-proto 0.11.14📝 Checklist