Repository navigation
fix: add OpenTelemetry span IDs to async capture_exception - #1123
Merged
Merged
Conversation
dustinbyrne
approved these changes
Oct 26, 2026
AsyncPosthog.capture_exception now adds the active span's $trace_id and $span_id even with capture_trace_context off, like Client.capture_exception. They follow the same SDK-value fill order and pair rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eli-r-ph
force-pushed
the
v1-async-exception-span-ids
branch
from
October 27, 2026 16:15
0461791 to
a950805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Client.capture_exceptionalways adds the active OpenTelemetry span's$trace_idand$span_id, butAsyncPosthog.capture_exceptionadds them only whencapture_trace_context=True. This makes the async client match the sync one. Stacked on #1122, which set where those IDs sit in the property order.AsyncPosthog.capture_exceptionnow adds the span IDs even withcapture_trace_contextoff, with the same order and pair rule as the sync client.💚 How did you test it?
capture_exceptionwithcapture_trace_context=False, like the sync ones. Two cases fail without this change.pytest posthog/test(5326 passed),ruff check,ruff format --check,mypyandmake public_api_checkpass locally.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Authored with Claude Code (Claude Opus 5.5), directed by @eli-r-ph.
🤖 Generated with Claude Code