Repository navigation
chore: upgrade @posthog/coherence to 1.10.1 - #5432
Open
pauldambra wants to merge 2 commits into
Open
pauldambra wants to merge 2 commits into
pauldambra wants to merge 2 commits into
Conversation
1.10.0 makes the Coherence PR comment say what each finding means and what to do, and marks the findings that are in files the pull request changed. The existing workflow gets the marks with no change, because the report reads the pull request's base from the GitHub event. The release-age exclusion moves to the new exact version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 4189fcb8-6fd5-428d-8c5f-4314d28e4dac
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
Coherence📄 0 spec file errors · ⛔ 0 broken rules · 🚪 2 unchecked inputs · 🐛 0 bugs that came back What is Coherence?Coherence compares the code with its spec files ( This check read 44 parts of the code and 7 rules. Note These findings do not make this check fail. None of these findings are in files that this pull request changes. You do not need to fix them in this pull request. 🚪 Unchecked inputs (2)
What this means and how to fix itInput from outside this code comes in at these places. The spec does not say what checks that input. 10 more places were already like this when Coherence was added. This list does not show them. To close one of these, find the place by its name in the
To get the line to add, run |
Contributor
Contributor
Node SDK compliance v2Commit: 2598051 Capture v0 — acceptance✅ 28 passed / ❌ 3 non-passing / Drill-down: run artifacts → ❌ server_snapshot_payload_false — failed_assertionExpected native data result Code: Failed step: acceptance/public/evaluate-flags.feature:868 the public snapshot outcomes should have these semantics: ❌ server_snapshot_payload_zero — failed_assertionExpected native data result Code: Failed step: acceptance/public/evaluate-flags.feature:868 the public snapshot outcomes should have these semantics: ❌ server_snapshot_payload_null — failed_assertionExpected native data result Code: Failed step: acceptance/public/evaluate-flags.feature:868 the public snapshot outcomes should have these semantics: Harness exit: 1; report validation exit: 1. Capture v1 — acceptance✅ 28 passed / ❌ 3 non-passing / Drill-down: run artifacts → ❌ server_snapshot_payload_false — failed_assertionExpected native data result Code: Failed step: acceptance/public/evaluate-flags.feature:868 the public snapshot outcomes should have these semantics: ❌ server_snapshot_payload_zero — failed_assertionExpected native data result Code: Failed step: acceptance/public/evaluate-flags.feature:868 the public snapshot outcomes should have these semantics: ❌ server_snapshot_payload_null — failed_assertionExpected native data result Code: Failed step: acceptance/public/evaluate-flags.feature:868 the public snapshot outcomes should have these semantics: Harness exit: 1; report validation exit: 1. Capture v0 — migration✅ 55 passed / ❌ 1 non-passing / Drill-down: run artifacts → ❌ migration/yaml-parity-v1/remote-flags-v1.feature::Omitted GeoIP settings default to enabled in flag requests — failed_assertionFlags field differs Code: Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:134 the first flags request field "geoip_disable" should equal JSON false Operation: Field: Expected: false Actual value: true Harness exit: 1; report validation exit: 1. Capture v1 — migration✅ 120 passed / ❌ 1 non-passing / Drill-down: run artifacts → ❌ migration/yaml-parity-v1/remote-flags-v1.feature::Omitted GeoIP settings default to enabled in flag requests — failed_assertionFlags field differs Code: Failed step: migration/yaml-parity-v1/remote-flags-v1.feature:134 the first flags request field "geoip_disable" should equal JSON false Operation: Field: Expected: false Actual value: true Harness exit: 1; report validation exit: 1. |
Contributor
|
Size Change: 0 B Total Size: 25.2 MB ℹ️ View Unchanged
|
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Not approved — this change needs a human reviewer.
Re-adding the stamphog label gives the same result unless the changed files change.
stamphog can't auto-review this pull request because two gates refused it. The deny-list gate matched the deps_toolchain category, which fits the dependency and toolchain files it touches: package.json, pnpm-lock.yaml, and pnpm-workspace.yaml. The tier gate also classified it as T2-never (a single-area chore), a class that is never handled automatically, even though the 14 changed lines are well within the size limit.
The author should ask a human reviewer to look at it. Splitting it up won't help, since size isn't the issue.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✗ | matches: deps_toolchain |
| size | ✓ | 14L, 3F substantive — within ceiling |
| tier | ✗ | classified as T2-never: T2-never (14L, 3F, single-area, chore) |
| stamphog 2.6.1 | .stamphog/policy.yml @ unknown · reviewed head d09d1e2 |
1.10.1 writes the PR comment in Simplified Technical English, folds explanations, colours the verdict, and adds icons. The release-age exclusion moves to the new exact version, and the lockfile changes only the Coherence entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 4189fcb8-6fd5-428d-8c5f-4314d28e4dac
pauldambra
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Coherence comment on each PR was hard to read and did not say what to do (see #5429). PostHog/coherence#154 made the report actionable (1.10.0). PostHog/coherence#155 rewrote it in Simplified Technical English, with folds, a coloured verdict and icons (1.10.1).
Changes
@posthog/coherencefrom^1.7.1to^1.10.1.minimumReleaseAgeExcludeentry to@posthog/coherence@1.10.1, so pnpm does not hold back the new release for 7 days.pnpm install --lockfile-onlyalso moved unrelated packages (for example@babel/parser), so I left those out.pnpm install --frozen-lockfile --lockfile-onlypasses, including the supply-chain check.With 1.10.1, the comment says what each finding means and how to fix it. It also marks findings in files the PR changed.
.github/workflows/coherence.ymldoes not need a change: the report reads the PR's base commit from the GitHub event.Release info Sub-libraries affected
Libraries affected
None. This is a root dev dependency, so no package needs a version bump or changeset.
Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
coherence spec --checkwith 1.10.1 on this repo finds 0 problems (the same as 1.7.1 after chore: clear the Coherence spec problems reported on every PR #5303).Created with PostHog Desktop
🤖 Generated with Claude Code