Repository navigation
ci(release): name excluded approvers in the Slack approval request - #5379
Conversation
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
There was a problem hiding this comment.
PostHog Review · Standard · reviewed 46d6eba: 1 Should fix.
This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.
Coherence4 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures 44 components, 7 bullets (5 invariants, 2 requirements), 4 problems Spec problems (spec --check)
Chokepoints: none declared. Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline
Close one with |
Problem
With the merge queue the push to
maincomes fromgithub-merge-queue[bot], so GitHub's "Prevent self-review" on theNPM Releaseenvironment never excludes the PR author or whoever queued it. The approval guard catches that after the fact and fails the release, but the Slack approval request gives no hint who's excluded, and nothing posts back when the guard rejects an approval. In run 39750702665 I queued #5273, approved it myself, the guard failed, and a teammate had to re-run and approve.Changes
Picks up PostHog/.github#82 (merged as f0431489d137b9e7474fc428cf176e4c668cc4a2), which teaches the shared
notify-approval-needed.ymlto name the excluded approvers and list the PRs in the Slack message when the caller lets it read PRs.pull-requests: readso the shared workflow can run the guard in report mode.PostHog/.githubpins to f0431489d137b9e7474fc428cf176e4c668cc4a2.CI only, no library code changes, so no changeset.
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
DRI: @ioannisj
Autonomy: Human-driven (agent-assisted)