Repository navigation
chore: update the no-traits API snapshot for the 4.0 API changes - #981
Merged
turnipdabeets merged 1 commit intoOct 28, 2026
Merged
Conversation
Drops the removed didReceiveFeatureFlags and adds the plain-closure setBeforeSend overloads, matching the Xcode 26.3 output in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dustinbyrne
approved these changes
Oct 28, 2026
dustinbyrne
left a comment
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
The no-traits snapshot now matches the existing public API and the Xcode 26.3 generated output. Both API snapshot checks pass. No actionable issues found.
AI-assisted review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The
Public API snapshotjob fails on #873:scripts/check-public-api.sh --no-traitsno longer matchesapi/posthog-ios.public-api.no-traits.txt. The snapshot still lists the removedPostHogSDK.didReceiveFeatureFlags(#965) and is missing the plain-closuresetBeforeSend(_:)overloads for events and logs (#974). This updates those three lines.💚 How did you test it?
scripts/check-public-api.sh --no-traitsnow differs only in how closure types are spelled (@Sendableon 6 symbols). Xcode 26.4 prints that and CI's Xcode 26.3 doesn't, and the default snapshot has the same local-only difference while passing in CI. So I didn't regenerate the whole file with 26.4.📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (address-comments skill) handled the PostHog Review finding on #873 as a follow-up into the v4 branch, instead of pushing to #873 directly.
🤖 Generated with Claude Code