Repository navigation
test(replay): gate flattened-content mask tests on the SessionReplay trait - #968
Merged
turnipdabeets merged 1 commit intoOct 27, 2026
Conversation
…lay trait The suite uses replay-only test helpers, so the no-traits iOS test build failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
turnipdabeets
merged commit Oct 27, 2026
e512d24
into
chore/v4-remove-deprecated
46 of 47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Build SDK (spm-no-traits)fails on #873.PostHogMaskFlattenedContentTestuses replay-only test helpers (host,phMaskTestWindowSize,collectMaskableRects), but unlike the other mask suites it wasn't gated on theSessionReplaytrait. This adds&& (!SWIFT_PACKAGE || SessionReplay)to its#if.Addresses the review comment on #873.
💚 How did you test it?
make buildTestsSpmTraitsIOSnow builds; on #873's head it failed with the errors from CI.📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code found the failing gate while triaging the open bot threads on #873. It's a test-only change, so there's no changeset.
🤖 Generated with Claude Code