Skip to content

fix: send non-finite numbers as null without slowing normal events - #394

Merged
eli-r-ph merged 2 commits into
v1from
v1-non-finite-null
Oct 27, 2026
Merged

eli-r-ph merged 2 commits into
v1from
v1-non-finite-null

Conversation

@eli-r-ph

@eli-r-ph eli-r-ph commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

v2 drops an event that holds a NaN or ±Inf property and reports it to Callback.Failure. posthog-go 1.36.1+ (#382) and the other SDKs send these values as null and keep the event, as sdk-specs#140 proposes. The fix in #382 normalizes and re-validates every event, which slows normal events, so v2 left it out.

This PR ports #382's normalizer and its tests (by Manoel), but runs the normalizer only after go-json fails on a non-finite float64.

  • prepareForSend encodes each event once, as before. On a non-finite number error only, it copies the properties with those numbers set to null and encodes again.
  • Any other encoding error still drops the event and reports it to Callback.Failure.
  • event_properties_json.go is fix: preserve events with non-finite numeric properties #382's file plus marshalEventPayload, the one-pass entry point.
  • The tests port fix: preserve events with non-finite numeric properties #382's tests to v2. New tests check that a finite event is encoded once, that the slower path changes only the non-finite values, and that a failing event is dropped without affecting its neighbor.
  • The migration guide and a changeset describe the behavior and its known gap.

Known gap, unchanged from the v1 branch: go-json writes a non-finite float32 as a bare NaN/+Inf token without an error. It also passes some invalid custom MarshalJSON output, such as {"value":01}. If no non-finite float64 sends the event down the slower path, the request is invalid JSON and capture rejects it. #382 fixes this as a side effect of re-validating every event.

I tried a cheaper check: a byte scan of the encoded event for a bare NaN/Inf value token. On a 1 KB event it cost about 0.7% of encode time. On a 450 KB AI event it cost 26–78% of encode time, depending on the text, so I left it out. Even a single IndexByte pass costs about 4%.

💚 How did you test it?

  • go build ./..., go vet ./..., gofmt -l . and go test -p 1 ./... pass. The new tests also pass with -race and with -count=100.
  • With prepareForSend changed back to a plain json.Marshal, 10 of the new and ported tests fail.
  • Benchmark of BenchmarkPrepareForSendFinite against the v1 base on an Apple M4 Pro (-count 10, benchstat):
Event Base sec/op This PR sec/op Base B/op This PR B/op allocs/op
typical, 871 B 5.757µs ± 2% 5.848µs ± 4% (~, p=0.218) 7.350Ki 7.348Ki 30 → 30
AI, ~450 KB 254.8µs ± 2% 254.0µs ± 3% (~, p=0.481) 504.3Ki 511.5Ki (~, p=0.075) 34 → 34

The allocation count of the typical event is 29 or 30 per process on the base too.

An event with a non-finite value costs about 2.2x (typical) and 5.3x (AI) to encode. Only those events pay this.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Written with Claude Code (Claude Opus 5.5). The design comes from the person driving the work: encode strictly first, as posthog-python does, and fall back to a sanitized copy only on failure.

The non-finite section of the migration guide is also added by #390, which says that v2 drops these events. Whichever PR merges second must keep this PR's wording.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eli-r-ph eli-r-ph self-assigned this Oct 26, 2026
@eli-r-ph
eli-r-ph marked this pull request as ready for review October 27, 2026 00:50
@eli-r-ph
eli-r-ph requested a review from a team as a code owner October 27, 2026 00:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eli-r-ph added a commit that referenced this pull request Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eli-r-ph
eli-r-ph merged commit cd66730 into v1 Oct 27, 2026
32 of 33 checks passed
@eli-r-ph
eli-r-ph deleted the v1-non-finite-null branch October 27, 2026 16:09
eli-r-ph added a commit that referenced this pull request Oct 28, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eli-r-ph added a commit that referenced this pull request Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eli-r-ph added a commit that referenced this pull request Oct 29, 2026
…390)

* fix(flags): load shared definitions without a secret key (#366)

* fix(flags): load shared definitions without a secret key

* fix(flags): make keyless cache consumers read-only

(cherry picked from commit 88d8397)

* chore(deps): bump the github-actions group with 2 updates (#373)

Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action).

Updates `github/codeql-action/init` from 4.38.2 to 4.38.3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@2892aa5...24c5418)

Updates `github/codeql-action/analyze` from 4.38.2 to 4.38.3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@2892aa5...24c5418)

---
updated-dependencies:
- dependency-name: github/codeql-action/init
  dependency-version: 4.38.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: github/codeql-action/analyze
  dependency-version: 4.38.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 155480d)

* chore(deps): bump google.golang.org/grpc from 1.83.1 to 1.83.2 in /otel (#377)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.83.1 to 1.83.2.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.83.1...v1.83.2)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-version: 1.83.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 863b330)

* chore(deps): bump github.com/klauspost/compress from 1.17.11 to 1.18.7 in /posthogmcpsdk in the go_modules group across 1 directory (#379)

chore(deps): bump github.com/klauspost/compress

Bumps the go_modules group with 1 update in the /posthogmcpsdk directory: [github.com/klauspost/compress](https://github.com/klauspost/compress).

Updates `github.com/klauspost/compress` from 1.17.11 to 1.18.7
- [Release notes](https://github.com/klauspost/compress/releases)
- [Commits](klauspost/compress@v1.17.11...v1.18.7)

---
updated-dependencies:
- dependency-name: github.com/klauspost/compress
  dependency-version: 1.18.7
  dependency-type: indirect
  dependency-group: go_modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 5c2220b)

* fix(mcp): set $exception_source and strip reserved exception metadata (#357)

* fix(mcp): set $exception_source and correct mechanism.synthetic

The mcp-analytics spec requires the $exception emitted alongside a failed
tool call to carry $exception_source: "mcp.tool_call", and to mark
mechanism.synthetic only for an isError result that carried no thrown
error. buildException set neither correctly: the source property was
absent, and synthetic was hardcoded true on a path only reached for a
thrown error.

Also strip $exception_source from caller-supplied properties, matching
how $exception_level is already protected.

Generated-By: PostHog Desktop
Task-Id: b4b6b8cc-da38-4c24-a978-9e2e9b5ac5f0

* fix(mcp): strip reserved exception metadata

* fix(mcp): keep mechanism.synthetic true until the adapter can mark synthesized errors

---------

Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: Ioannis J <yiannis@posthog.com>
(cherry picked from commit de638c7)

* fix(flags): match explicit null properties with string operators (#381)

(cherry picked from commit 870af8a)

* feat(flags): honor experiment holdouts in local flag evaluation (#360)

* feat(flags): honor experiment holdouts in local flag evaluation

Local evaluation ignored `filters.holdout`, so an identifier inside an experiment's holdout was bucketed into a regular variant and disagreed with the server, silently and with no fallback.

Holdout resolution now runs after the inactive-flag check and before release conditions, returning the synthetic `holdout-<id>` variant. Membership uses the flag-level bucketing identity (group key for group-aggregated flags, device id for device-bucketed flags, distinct id otherwise) and the server's hash of `holdout-<value>`: the "-" separator, not the "." used by rollout hashing, selects a different population. Percentages are clamped to 0-100 without truncating fractions, compared inclusively, and 100 includes everyone without hashing. A holdout missing `id` or `exclusion_percentage` is skipped, leaving ordinary evaluation unchanged.

Tested: go build, go vet, gofmt, make api-diff, and go test -race -count=1 ./... at the repository root.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: 2887d167-f4e8-446a-a056-202893f6ecd9

* fix(flags): keep device-bucketed partial holdouts inconclusive without a device id

---------

Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: Ioannis J <yiannis@posthog.com>
(cherry picked from commit d170fc5)

* chore(deps): bump the github-actions group with 4 updates (#385)

Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action), [github/codeql-action/analyze](https://github.com/github/codeql-action), [actions/create-github-app-token](https://github.com/actions/create-github-app-token) and [pnpm/setup](https://github.com/pnpm/setup).

Updates `github/codeql-action/init` from 4.38.3 to 4.39.0
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@24c5418...6f2ac81)

Updates `github/codeql-action/analyze` from 4.38.3 to 4.39.0
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@24c5418...6f2ac81)

Updates `actions/create-github-app-token` from 3.2.0 to 3.3.0
- [Release notes](https://github.com/actions/create-github-app-token/releases)
- [Changelog](https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md)
- [Commits](actions/create-github-app-token@bcd2ba4...64ab729)

Updates `pnpm/setup` from 3.0.0 to 3.1.1
- [Release notes](https://github.com/pnpm/setup/releases)
- [Commits](pnpm/setup@fbda4c8...a088197)

---
updated-dependencies:
- dependency-name: github/codeql-action/init
  dependency-version: 4.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: github/codeql-action/analyze
  dependency-version: 4.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: actions/create-github-app-token
  dependency-version: 3.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: pnpm/setup
  dependency-version: 3.1.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 6ffac5a)

* feat(otel): add per-request context to span processor (#371)

* feat: span processor request context

* fix: span processor review feedback

* fix: span processor review follow-ups

(cherry picked from commit c203229)

* chore(deps): bump github.com/klauspost/compress from 1.17.11 to 1.18.7 in /otel (#380)

chore(deps): bump github.com/klauspost/compress in /otel

Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.11 to 1.18.7.
- [Release notes](https://github.com/klauspost/compress/releases)
- [Commits](klauspost/compress@v1.17.11...v1.18.7)

---
updated-dependencies:
- dependency-name: github.com/klauspost/compress
  dependency-version: 1.18.7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 460c7e6)

* chore: release v1.35.0 [version bump] [skip ci]

(cherry picked from commit 5b7997a)

* chore: release v1.35.1 [version bump] [skip ci]

(cherry picked from commit 4139880)

* chore: release v1.35.2 [version bump] [skip ci]

(cherry picked from commit 87a8371)

* chore: release v1.35.3 [version bump] [skip ci]

(cherry picked from commit 8b65bef)

* chore: release v1.36.0 [version bump] [skip ci]

(cherry picked from commit 4f9ba34)

* build!: release the otel bridge in lockstep with the core major

The otel bridge now imports the core SDK for the request context, so it
moves to github.com/posthog/posthog-go/otel/v2 and shares the core release
version, like posthogmcpsdk. The release workflow sets both nested modules'
core requirement to the new version and tags them after the core release.
Both nested modules run the pinned-core build check through one script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: require signed commits in contributor docs (#388)

Contributors often open PRs with unsigned commits because signing isn't documented here.

(cherry picked from commit 56aa91d)

* fix(flags): fall back for incompatible local regex evaluation (#387)

* fix(flags): fall back for incompatible local regex evaluation

* fix(flags): preserve regex fallback priority and bound repetition scans

* fix(flags): bound malformed escape scans and reject reversed counts

* fix(flags): defer malformed regex repetitions

(cherry picked from commit e8c7d37)

* feat(otel): add opt-in exception trace context (#374)

* feat(otel): add opt-in exception trace context

Generated-By: PostHog Desktop
Task-Id: 5681be44-4986-48db-b140-1bda88f75f96

* fix(otel): preserve request trace overrides for enqueue clients

Generated-By: PostHog Desktop
Task-Id: 5681be44-4986-48db-b140-1bda88f75f96

(cherry picked from commit 729bcf7)

* fix(otel)!: add derived exception trace IDs only as a pair

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: release v1.36.1 [version bump] [skip ci]

(cherry picked from commit aef332c)

* chore: release v1.36.2 [version bump] [skip ci]

(cherry picked from commit 32f2522)

* chore: release v1.37.0 [version bump] [skip ci]

(cherry picked from commit 5d73532)

* docs: note non-finite numbers and default trace IDs in the v2 migration guide

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: give the non-finite number and trace ID notes their own sections

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: v2 sends non-finite numbers as null (#394)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(otel): add request context to application spans (#375)

* feat(otel): add request context to application spans

Generated-By: PostHog Desktop
Task-Id: 5681be44-4986-48db-b140-1bda88f75f96

* fix: stop context enrichment after processor shutdown

Generated-By: PostHog Desktop
Task-Id: 5681be44-4986-48db-b140-1bda88f75f96

* fix: skip span context for disabled clients

Generated-By: PostHog Desktop
Task-Id: bfd18848-e498-4352-a58a-b9ba85de4198
(cherry picked from commit 94ff576)

* chore: release v1.38.0 [version bump] [skip ci]

(cherry picked from commit b0a9fae)

* fix(otel): build the context span processor against the v2 core

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(otel): say which trace IDs can mix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Dustin Byrne <dustin@posthog.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: Ioannis J <yiannis@posthog.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Carlos Marchal <carlos@posthog.com>
Co-authored-by: releaser-posthog-go[bot] <250614987+releaser-posthog-go[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Anna Garcia <11654201+turnipdabeets@users.noreply.github.com>
Co-authored-by: Paul D'Ambra <paul@posthog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants