Repository navigation
feat(replay): default screenshotScale to null so native screens use the Android SDK default #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "posthog_flutter": minor | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [suggestion] I would keep this as a minor, same as Android: the option is |
||
| --- | ||
|
|
||
| **Breaking:** Change `PostHogSessionReplayConfig.screenshotScale` from `double` to `double?` with a `null` default, so native screens recorded with `captureNativeScreens` on Android pick up posthog-android's one-pixel-per-dp default instead of physical resolution. Flutter screens still capture at one pixel per logical pixel. Set `screenshotScale: 1.0` to keep native screens at physical resolution. Code that reads the value into a `double` needs a null check. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,7 +67,7 @@ android { | |
| testImplementation 'org.robolectric:robolectric:4.14.1' | ||
| testImplementation 'junit:junit:4.13.2' | ||
| testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.10.1' | ||
| implementation 'com.posthog:posthog-android:[3.72.9,4.0.0)' | ||
| implementation 'com.posthog:posthog-android:[3.74.0,4.0.0)' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] Worth making the floor |
||
| } | ||
|
|
||
| testOptions { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.