Repository navigation
chore: stop passing RRStyle to replay screenshot frames - #684
Merged
turnipdabeets merged 1 commit intoOct 29, 2026
Merged
Conversation
6 tasks done
Contributor
posthog-flutter Compliance ReportDate: 2026-10-29 19:17:25 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
turnipdabeets
marked this pull request as ready for review
October 29, 2026 15:17
Base automatically changed from
chore/v6-adopt-posthog-android-4
to
chore/v6-adopt-posthog-ios-4
October 29, 2026 16:01
turnipdabeets
force-pushed
the
chore/v6-adopt-posthog-ios-4
branch
from
October 29, 2026 19:10
fd88c7e to
7eebbca
Compare
posthog-android 4.0 drops RRStyle and the wireframe tree fields from the internal RRWireframe; screenshot frames don't need a style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
turnipdabeets
force-pushed
the
chore/v6-drop-rrstyle
branch
from
October 29, 2026 19:12
7ca6c51 to
82a121d
Compare
dustinbyrne
approved these changes
Oct 29, 2026
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
The Android screenshot constructor matches the trimmed native replay model, and omitting the empty style preserves player behavior. Native 4.x dependency availability and successful native builds/tests remain prerequisites for shipping.
AI-assisted review.
turnipdabeets
merged commit Oct 29, 2026
284cdec
into
chore/v6-adopt-posthog-ios-4
20 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked on #663 and depends on PostHog/posthog-android#908. posthog-android 4.0 removes
RRStyle, so #663 won't compile for Android without this change.💡 Motivation and Context
posthog-android 4.0 removes wireframe session replay (PostHog/posthog-android#908). Since screenshot frames are the only kind left, the internal
RRWireframenow keeps onlyid,x,y,width,height,typeandbase64, andRRStyleis deleted.SnapshotSenderpassedstyle = RRStyle(), which only serialized an empty"style": {}.This PR stops passing it. Android screenshot frames from Flutter now have the same shape as iOS 4.0 frames, which never sent
style. The player doesn't readstylefor screenshots.💚 How did you test it?
posthog7.0.0 /posthog-android4.0.0 from chore!: remove wireframe session replay capture posthog-android#908 to a local Maven repo and ran./gradlew :posthog_flutter:testDebugUnitTestfromexample/androidagainst it: 57 tests pass, includingSnapshotSenderTestandSnapshotSenderEncodingTest.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file (no user-visible change; covered by the existingv6-posthog-android-4changeset)🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Claude Code (Opus 5.5) at the maintainer's request, as a follow-up to trimming the core replay classes in PostHog/posthog-android#908.
🤖 Generated with Claude Code