Repository navigation
fix: let a caller $process_person_profile override the personless option - #911
Merged
turnipdabeets merged 1 commit intoOct 29, 2026
Conversation
…ption Reverts the person-processing half of #905. A passed or registered `$process_person_profile` property again stops the SDK from adding `process_person_profile: false` when person processing is off, so the caller wins, as the client property precedence in sdk-specs `capture` (#143) requires. The send still hoists the property into the option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
#905 made the SDK add
process_person_profile: falseeven when a passed or registered$process_person_profileproperty was set, following one sentence in the draft capture v1 spec (PostHog/sdk-specs#146: "an option set by any layer wins over a legacy property set by any layer"). That contradicts the client property precedence already on sdk-specsmain(PostHog/sdk-specs#143), where a caller$process_person_profile: truewith person profilesneverkeepstrue— the case the review bot flagged on #903.This reverts only the person-processing half of #905: a non-null legacy property, passed or registered, again stops the SDK from adding its personless option, and the send hoists the property into the option. The 2xx-without-results half of #905 stays. It also fixes JS fatal crashes from identified users arriving personless through the React Native plugin.
The spec sentence is being raised on PostHog/sdk-specs#146.
💚 How did you test it?
./gradlew spotlessCheck :posthog:testforPostHogCaptureOptionsTest,PostHogPersonProfilesTestandPostHogCaptureV1Testpass.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file (reverted fix: keep the personless option over a legacy property and drop a 2xx without results #905's line in the existing 4.0 major changeset)🤖 Agent context
Autonomy: Human-driven (agent-assisted)
PostHog.kt, test, changeset and migration-guide hunks of fix: keep the personless option over a legacy property and drop a 2xx without results #905's first commit; the migration guide keeps fix: keep the personless option over a legacy property and drop a 2xx without results #905's proxy-body bullet.🤖 Generated with Claude Code