Repository navigation
fix: warn about empty and personal API keys without debug and log rejected batches - #909
Merged
turnipdabeets merged 1 commit intoOct 29, 2026
Conversation
turnipdabeets
force-pushed
the
fix/v4-terminal-status-log
branch
from
October 29, 2026 14:53
c5be9ca to
62d0812
Compare
dustinbyrne
approved these changes
Oct 29, 2026
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Startup configuration errors use the existing warning channel, while terminal-batch diagnostics remain debug-only and preserve retry/split behavior.
AI-assisted review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Follow-up to #903, agreed with the capture v1 spec author on sdk-specs#146:
phx_...) setup errors print withoutdebug. They now uselogWarninginPostHogandPostHogStateless, so an app whose SDK is disabled at setup sees why.Flushing failed with <status>, dropping <n> records.(debug-only, like the other per-flush lines, since it can repeat during an outage).💚 How did you test it?
delete files if erroredasserts the new line../gradlew :posthog:test --tests 'com.posthog.internal.PostHogQueueTest' --tests 'com.posthog.PostHogTest' --tests 'com.posthog.PostHogStatelessTest' spotlessCheckpass.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file (updated the existing 4.0 major changeset)🤖 Agent context
Autonomy: Human-driven (agent-assisted)
🤖 Generated with Claude Code