[turnipdabeets]

Note

Stacked on the 4.0 integration PR #871. Merges into chore/v4-remove-deprecated, not main.

💡 Motivation and Context

Addresses #563: the callback now receives the loaded flags and whether loading failed.

Brings the Android flags callback to parity with posthog-ios 4.0 (PostHogFeatureFlagsLoaded) and Flutter 6.

PostHogConfig.onFeatureFlags and reloadFeatureFlags() now take a new PostHogFeatureFlagsCallback. Its loaded() receives a PostHogFeatureFlagsLoaded with:

• flags: the keys of the enabled flags
• variants: their values (true or the variant string)
• errorsLoading: whether the latest load failed (the values are then the last known ones)

Every path that invoked the old callback now passes an accurate result, including failed requests, a disabled SDK, and bootstrap.

config.onFeatureFlags = PostHogFeatureFlagsCallback { loaded ->
    if (!loaded.errorsLoading && loaded.variants["new-checkout"] == "test") {
        // ...
    }
}

Why a new type instead of changing PostHogOnFeatureFlags: core's public types are also part of posthog-server's API. Changing PostHogOnFeatureFlags.loaded() would force a server major for a callback the server can only fill with empty data (it evaluates flags per call). So:

• PostHogOnFeatureFlags moves from core into posthog-server, same package and shape, so server users' source and binaries keep working. Android no longer sees it.
• The server already calls its own callback directly, so it no longer passes one to the core config (core's stateless client never called it).
• posthog-server gets a minor bump, since it now depends on core 7.0.
• The server can drop or replace it in its own major.

The other core types the server exposes (FeatureFlagResult, PostHogBeforeSend, PostHogEncryption, PostHogIntegration) are unchanged.

For reviewers: a blank distinctId reports errorsLoading = true, since no request is made.

💚 How did you test it?

• ./gradlew spotlessCheck apiCheck :posthog:test :posthog-server:test :posthog-android:testDebugUnitTest pass, and the Android sample compiles.
• PostHogRemoteConfigTest and PostHogBootstrapTest assert the result passed on success, failure, and bootstrap.
• The server's tests are unchanged apart from asCoreConfig no longer setting the core callback.
• posthog-server.api only gains PostHogOnFeatureFlags (moved in, unchanged).

📝 Checklist

• All commits are signed (see Commit signing)
• I reviewed the submitted code.
• I added tests to verify the changes.
• I updated the docs if needed.
• No breaking change or entry added to the changelog.

If releasing new changes

• Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Claude Code (Claude Opus 5.5) implemented the change after a cross-SDK flags API review (iOS, Android, Flutter, React Native). A first version changed PostHogOnFeatureFlags in place and bumped the server to a major; it was reworked to move the old type into posthog-server so the server stays untouched until its own major.

🤖 Generated with Claude Code

[posthog]

PostHog Review · Standard · reviewed 90beca5: 2 Should fix.

See this review and its findings in PostHog Review. Comment @posthog review --deep for a Deep review. A Deep review takes longer and looks deeper than a Standard review.

[posthog]

PostHog Review · Standard · reviewed 46fca5a: 1 Should fix.

[dustinbyrne]

AI-assisted review. The readable-cache and bootstrap fixes are verified. One Direct Boot cache-availability regression remains; details and executed base/head evidence are inline.

[posthog]

PostHog Review · Standard · reviewed 8aaa5a4: 1 Must fix, 1 Should fix.

This is review round 3 on this pull request. When findings keep coming back in the same code, the approach is usually the problem. Before the next fix, check whether a different design would remove the whole class of findings.

[dustinbyrne]

AI-assisted review. Verified reset invalidation, Direct Boot recovery, and retained cached values on failed loads. No remaining findings in the reviewed changes.