Repository navigation
ci: add trusted SDK benchmark report workflow - #84
Open
dustinbyrne wants to merge 14 commits into
Open
dustinbyrne wants to merge 14 commits into
dustinbyrne wants to merge 14 commits into
Conversation
This was referenced Oct 27, 2026
5 tasks done
turnipdabeets
left a comment
Contributor
There was a problem hiding this comment.
[question] The trust boundary looks solid to me: workflow_run only, no PR checkout, scoped token, artifacts validated against the API. One gap on the fork side, inline.
turnipdabeets
left a comment
Contributor
There was a problem hiding this comment.
[question] Thanks for the fork fix: the owner/branch lookup still requires the exact head SHA and repos, and the tests now reproduce the real empty response. One thing from the new comment rendering, inline.
turnipdabeets
approved these changes
Oct 29, 2026
turnipdabeets
left a comment
Contributor
There was a problem hiding this comment.
Both fixes check out: fork PRs resolve through the owner/branch lookup with the same identity checks, and the diagnostics link now points at the publishing run. 377 tests pass on 2a6111d. One follow-up on the pin, inline.
5 tasks done
feliperalmeida
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add shared SDK performance reports to pull requests, so reviewers can see how a change affects flag evaluation, event capture, CPU time, allocations and memory usage.
The report starts with changes worth reviewing, uses readable test names and time/size units, and keeps all measurements under View all results. A change is flagged when the median differs by at least 5% and all six paired measurements agree on direction. This is an informational noise filter, not a performance merge gate.
Implementation
SDK integrations: Node, Python, .NET, and Ruby.
Validation
queue: maxsyntax.Rollout
Automatic comments activate once the SDK caller workflows land on their default branches. After this PR is squash-merged, follow up by repinning the shared action and SDK callers to commits on
main.Agent context
Autonomy: Human-driven (agent-assisted).
Implemented with Pi and independently reviewed by fresh read-only agents.