Repository navigation
ci(release): pin the approval guard to the merged #82 commit - #83
Merged
Merged
Conversation
ioannisj
marked this pull request as ready for review
October 23, 2026 07:40
ioannisj
enabled auto-merge (squash)
October 23, 2026 07:40
Piccirello
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#82 shipped
notify-approval-needed.ymlwith itsrelease-approval-guardstep pinned to 71adbfe, the head of the PR branch, becausemode: reportdidn't exist onmainyet. #82 was squash-merged, so that commit isn't reachable from any branch anymore. It still resolves through the PR's ref, but it isn't a commit onmain, and the# pr-82comment says as much.Changes
Bumps the pin to f043148, the #82 merge commit on
main, and changes the comment to# main. No behaviour change: therelease-approval-guardaction tree is byte-identical between the two commits.Testing
git diff 71adbfe4bf1dd9be4ab5debcb4a5b70789306d26 f0431489d137b9e7474fc428cf176e4c668cc4a2 -- .github/actions/release-approval-guardis empty.actionlintis clean onnotify-approval-needed.yml.node --test .github/actions/release-approval-guard/guard.test.mjs: 26 pass.DRI: @ioannisj
Autonomy: Human-driven (agent-assisted)