Repository navigation
fix: channel-config-exposure - #568
Merged
Merged
Conversation
Storage and notification channel configs (S3 keys, SMTP passwords, webhook URLs) reached the browser of users who are not allowed to manage them (GHSA-xfcg-76xx-w539): - settings page: channels are only loaded for owners/admins - project page: policies no longer embed the full channel rows - database data action: channels are reduced to id/name/provider/enabled - backup list action: storage channel limited to id/name/provider - organization channel services: system-wide channels, and channels owned by another organization, are returned without their config
The database page masks credentials on first render, but the getDatabaseDataAction poll (every 4s) returned the raw config again.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.