Repository navigation
feat: add widget_id to the widget url as a query string parameter - #26
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new widgetId parameter to both the Android and iOS SDKs, allowing it to be appended as a query parameter to the widget URL. However, inserting widgetId in the middle of existing parameters breaks backward compatibility for existing positional calls in both Kotlin and Swift. The feedback recommends reordering the parameters in public APIs and internal methods so that widgetId is placed after existing parameters with a default value of null (or nil), and updating all corresponding calls and tests to maintain compatibility.
hionay
approved these changes
Sep 21, 2026
onurhanavci
approved these changes
Sep 21, 2026
cantugdonmez
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.