Skip to content

feat: make pogly cli compatible with linux distros - #4

Merged
Lethalchip merged 10 commits into
PoglyApp:mainfrom
ItsBr0dyy:main
Sep 17, 2026
Merged

Lethalchip merged 10 commits into
PoglyApp:mainfrom
ItsBr0dyy:main

Conversation

@ItsBr0dyy

Copy link
Copy Markdown
Contributor

makes pogly cli compatible with linux distros by installing it with install.sh

@Lethalchip

Copy link
Copy Markdown
Member

Thanks for this, the XDG paths and the exec-bit handling look right. A few things before it can go in:

  1. install.sh is incomplete: it only downloads the pogly launcher into ~/.local/bin. The launcher expects pogly-cli at $XDG_DATA_HOME/Pogly/cli/bin/<version>/pogly-cli (default ~/.local/share/...) plus a version pointer file next to bin/, so a fresh install currently prints "pogly-cli is not installed" and exits 1. Please mirror install.ps1: resolve the latest tag, download both binaries into that layout, write the pointer, chmod +x both.
  2. cargo clippy --all-targets -- -D warnings fails: bail in crates/cli/src/versionstore.rs:3 is now an unused import.
  3. cargo fmt --check fails on paths.rs (launcher_path) and versionstore.rs (set_pointer). Please run cargo fmt.
  4. Minor: the chmod +x step in release.yml is a no-op (GitHub strips permission bits from release assets; the post-download chmod you already added is the right place). Please also add a Linux install section to the README.

CI didn't run since this is from a fork; I'll approve the run once the above is pushed. Will close out #3 .

@ItsBr0dyy

Copy link
Copy Markdown
Contributor Author

i kind of rushed because im trying to go to sleep rn. if anything needs fixed via your comments, i can fix them in the morning

@Lethalchip
Lethalchip self-requested a review September 9, 2026 06:20
Comment thread install.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rc-file choice checks $ZSH_VERSION, but under curl ... | bash the script always runs in bash, so zsh users get PATH appended to .bashrc and pogly is never found. Either pick the file from $SHELL (case "$(basename "$SHELL")" in zsh) ...) or skip rc editing entirely and symlink the launcher into ~/.local/bin, which is already on PATH on most distros.

Comment thread README.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first code block under the title lost its ``` fences and a line break got inserted inside "#82a5ff" (looks like an editor auto-format).

Comment thread README.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%LOCALAPPDATA%\Pogly\cli\bin<version>\pogly-cli.exe is missing the backslash before <version>.

@Lethalchip Lethalchip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three small things and GTG!

@Lethalchip
Lethalchip merged commit 3575e28 into PoglyApp:main Sep 17, 2026
2 checks passed
@ItsBr0dyy

Copy link
Copy Markdown
Contributor Author
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants