Repository navigation
feat: make pogly cli compatible with linux distros - #4
Conversation
|
Thanks for this, the XDG paths and the exec-bit handling look right. A few things before it can go in:
CI didn't run since this is from a fork; I'll approve the run once the above is pushed. Will close out #3 . |
|
i kind of rushed because im trying to go to sleep rn. if anything needs fixed via your comments, i can fix them in the morning |
There was a problem hiding this comment.
The rc-file choice checks $ZSH_VERSION, but under curl ... | bash the script always runs in bash, so zsh users get PATH appended to .bashrc and pogly is never found. Either pick the file from $SHELL (case "$(basename "$SHELL")" in zsh) ...) or skip rc editing entirely and symlink the launcher into ~/.local/bin, which is already on PATH on most distros.
There was a problem hiding this comment.
The first code block under the title lost its ``` fences and a line break got inserted inside "#82a5ff" (looks like an editor auto-format).
There was a problem hiding this comment.
%LOCALAPPDATA%\Pogly\cli\bin<version>\pogly-cli.exe is missing the backslash before <version>.
Lethalchip
left a comment
There was a problem hiding this comment.
three small things and GTG!

makes pogly cli compatible with linux distros by installing it with
install.sh