Recover missing album tracks during incremental scans - #127
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental sync can leave an imported album incomplete when MediaStore exposes additional tracks with timestamps older than the last sync. The folder picker can count all 16 files while the library still shows only the 3 tracks imported earlier.
Compare the eligible MediaStore IDs with the local database during the existing deletion scan. If any IDs are missing locally, query without a timestamp cutoff and retain the existing unchanged-song checks and metadata-edit preservation. Normal incremental scans resume once the IDs match.
Related to #126. The reporter's original files were unavailable; the regression test covers a reproducible cause of the reported mismatch.
Validation:
main.SyncWorkerTestinstrumented tests passed on Android 16. The new regression failed with 3/16 tracks before the fix and recovered all 16 afterward, preserved an edited title, and verified that the next scan uses its timestamp filter again.lintDebugran and reported 94 existing errors in unchanged playback and translation files; none are in the changed code.