selection function - #3673
Open
Wunka wants to merge 1 commit into
Open
selection function#3673Wunka wants to merge 1 commit into
Wunka wants to merge 1 commit into
Conversation
IntegratedQuantum
requested changes
Oct 4, 2026
| } | ||
| } | ||
|
|
||
| pub fn getDirection(_: *const @This(), comptime side: main.sync.Side) Vec3f { |
Member
There was a problem hiding this comment.
Why are these in server.Entity when they are meant to be side-agnostic?
Also note that server.Entity will probably need to be dissolved in the context of #3241, it would be best to find more suitable for these now instead of making #3241 more difficult.
Also as discussed in the meeting, the crosshair direction should probably be what's sent to the server as a rotation.
As for getSelected, I'd suggest to just change the signature of MeshSelection isntead of making a new helper function.
| mesh_storage.removeBreakingAnimation(breaking.blockPos); | ||
| swinging.currentSwingProgress = 0; | ||
| breaking.blockPos = selected.blockPos; | ||
| breaking.progress = 0; |
Member
There was a problem hiding this comment.
Why was this part changed from the previous PR? Mistake in merge conflict resolution?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second pr created of #3649
Instead of saving the mesh selection in global variables its now in the return struct of the select function