Skip to content

docs(video): correct the shoot sheet -- #1023's own hypothesis does not survive contact - #1340

Merged
PipFoweraker merged 1 commit into
mainfrom
video-sheet-correction
Aug 30, 2026
Merged

docs(video): correct the shoot sheet -- #1023's own hypothesis does not survive contact#1340
PipFoweraker merged 1 commit into
mainfrom
video-sheet-correction

Conversation

@PipFoweraker

Copy link
Copy Markdown
Owner

Section 0 of the shoot sheet was written this morning from the issue title and a resemblance to the stale-class-cache symptom in CLAUDE.md. It told Pip that recording from source risks filming a game that does not run. That overstates the risk, and a sheet whose loudest warning is wrong is worse than one that says less.

Two checks, neither run in the month #1023 has been open

1. Its leading hypothesis is falsified. #1023 proposes start_new_game() was refused for want of force=true. That force=true landed 2026-07-27 in #983 (d36cff9d):

git merge-base --is-ancestor d36cff9d 3f408038   # -> present

It was already in the exact commit the failure was observed on (3f408038, 2026-07-28; observed 2026-07-29). Every fresh-boot path in main_ui._boot_game() passes it today — resume, load, and new-game at main_ui.gd:828.

2. The symptom is covered by a passing regression test. godot/tests/unit/test_game_start_actionable.gd (added for #664) boots the real main.tscn through _boot_game and asserts the game either presents an initial event dialog or emits a non-empty action list with the buttons enabled — precisely "no action buttons". From today's fast-gate XML:

name="tests/unit/test_game_start_actionable.gd" tests="1" failures="0" skipped="0"

So #1023 is probably stale, and what remains is the third candidate its own author listed and said to rule out first — an artefact of running from source with a warm .godot — which is exactly the check nobody has done.

What changes for tonight

Recording from source is very likely fine with the pre-flight. The shipped build is still the better choice, but for the ordinary reason (it is what a funder downloads) rather than because the source path is dangerous. The correction is added in place, above the original paragraph, rather than quietly editing the wrong claim away.

The limit, stated

The regression test drives the boot path in-engine under GUT. It is not a human clicking welcome -> config -> main on an exported binary. Strong evidence, not proof. The decisive test is the one #1023 asks for in its own triage order and nobody has run: launch a built artifact and look. This machine has an X display and could, but opening a game window on Pip's laptop while he is at a conference is not a thing to do unasked.

Follow-up for Pip, not actioned here

#1023 is labelled LEAGUE-CRITICAL and has been open since 2026-07-29 on a hypothesis a two-command check disproves. It wants re-triage or closing — his call, not a side effect of a video shoot.

Ladder-Impact: none — no gameplay-surface file changed.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

Generated with Claude Code

https://claude.ai/code/session_018FeT1mRNm7NZmd3Y2nsaKc

…ot survive contact

The sheet's section 0 was written this morning from the issue title and a
resemblance to the stale-class-cache symptom in CLAUDE.md. It told Pip that
recording from source risks filming a game that does not run. Investigated this
afternoon, that overstates the risk, and a sheet whose loudest warning is wrong is
worse than one that says less.

TWO CHECKS, BOTH CHEAP, NEITHER RUN IN THE MONTH THE ISSUE HAS BEEN OPEN

1. #1023's LEADING HYPOTHESIS IS FALSIFIED. It proposes that start_new_game() was
   refused for want of force=true. That force=true landed 2026-07-27 in #983
   (d36cff9), and

       git merge-base --is-ancestor d36cff9 3f40803

   confirms it was already present in the exact commit the failure was observed
   on (3f40803, 2026-07-28; observed 2026-07-29). Every fresh-boot path in
   main_ui._boot_game() passes it today -- the resume branch, the load branch and
   the new-game branch at main_ui.gd:828.

2. THE SYMPTOM IS COVERED BY A PASSING REGRESSION TEST.
   godot/tests/unit/test_game_start_actionable.gd, added for #664, boots the REAL
   main.tscn through _boot_game and asserts the game either presents an initial
   event dialog or emits a non-empty action list with the buttons enabled. That is
   precisely "no action buttons". From today's fast-gate XML:

       name="tests/unit/test_game_start_actionable.gd" tests="1" failures="0" skipped="0"

So #1023 is probably stale. What remains is the third candidate its own author
listed and said to rule out FIRST -- an artefact of running from source with a
warm .godot -- which is exactly the check nobody has done.

WHAT CHANGES FOR TONIGHT

Recording from source is very likely fine with the pre-flight. The shipped build
is still the better choice, but for the ordinary reason (it is what a funder
downloads) rather than because the source path is dangerous. The correction says
so in those words, in place, rather than quietly editing the original claim away.

THE LIMIT, STATED

The regression test drives the boot path in-engine under GUT. It is not a human
clicking welcome -> config -> main on an exported binary. Strong evidence, not
proof. The decisive test is still the one #1023 asks for in its own triage order
and nobody has run: launch a built artifact and look. This machine has an X
display and could do it, but opening a game window on Pip's laptop while he is at
a conference is not a thing to do unasked.

FOLLOW-UP FOR PIP, NOT ACTIONED HERE: #1023 is labelled LEAGUE-CRITICAL and has
been open since 2026-07-29 on a hypothesis that a two-command check disproves. It
wants re-triage or closing, and that is his call rather than a side effect of a
video shoot.

Ladder-Impact: none -- no gameplay-surface file changed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018FeT1mRNm7NZmd3Y2nsaKc
@PipFoweraker
PipFoweraker merged commit 7d5f282 into main Aug 30, 2026
13 checks passed
@PipFoweraker
PipFoweraker deleted the video-sheet-correction branch August 30, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant