Skip to content

Feat: MyBookmarkCard에서 닉네임 표시 형식 수정 - #300

Merged
jjangminii merged 1 commit into
developfrom
feat/#299/design-detail
Mar 7, 2026
Merged

jjangminii merged 1 commit into
developfrom
feat/#299/design-detail

Conversation

@jjangminii

@jjangminii jjangminii commented Mar 7, 2026 •

Copy link
Copy Markdown
Collaborator

📌 Related Issues

관련된 Issue를 태그해주세요. (e.g. - close #25)

📄 Tasks

  • MyBookmarkCard에서 닉네임 표시 형식 수정

⭐ PR Point (To Reviewer)

📷 Screenshot

image

Summary by CodeRabbit

  • 버그 수정
    • 북마크 저장 시 닉네임 표시 형식이 개선되었습니다. 괄호가 제거되어 더욱 간결한 UI로 변경되었습니다.

@jjangminii jjangminii self-assigned this Mar 7, 2026
@jjangminii jjangminii linked an issue Mar 7, 2026 that may be closed by this pull request
@vercel

vercel Bot commented Mar 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pinback-client-client Ready Ready Preview, Comment Mar 7, 2026 4:59am
pinback-client-landing Ready Ready Preview, Comment Mar 7, 2026 4:59am

@github-actions github-actions Bot added the feat 기능 개발하라 개발 달려라 달려 label Mar 7, 2026
@coderabbitai

coderabbitai Bot commented Mar 7, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 84141b8d-3484-409a-87f8-55e4770c05c7

📥 Commits

Reviewing files that changed from the base of the PR and between ebbdcef and bcee76b.

📒 Files selected for processing (1)
  • packages/design-system/src/components/card/MyBookmarkCard.tsx

Walkthrough

MyBookmarkCard 컴포넌트에서 'save' variant일 때 닉네임 표시 텍스트가 괄호를 제거한 형식으로 변경됩니다. "(nickname)님의 핀" 형식에서 "nickname님의 핀"으로 변경되며, 제어 흐름과 주변 UI는 유지됩니다.

Changes

Cohort / File(s) Summary
북마크 카드 닉네임 표시
packages/design-system/src/components/card/MyBookmarkCard.tsx
'save' variant에서 닉네임 주변의 괄호를 제거하여 텍스트 포맷 변경. 텍스트 콘텐츠만 수정됨.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

feat

Suggested reviewers

  • jllee000
  • constantly-dev

Poem

🐰 괄호 떨어지고 닉네임이 반짝,
핀 카드의 옷을 깔끔하게 맞춰,
디자인의 마지막 터치, 이제 정말 예뻐! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 주요 내용(MyBookmarkCard의 닉네임 표시 형식 수정)을 명확하게 설명하고 있습니다.
Description check ✅ Passed PR 설명이 템플릿 구조를 따르고 있으며 관련 이슈(#299), 작업 내용, 스크린샷이 포함되어 있습니다.
Linked Issues check ✅ Passed PR의 코드 변경사항이 이슈 #299의 요구사항(잡핀 카드 이름 괄호 제거)을 충족합니다. 이슈 #25는 다른 컴포넌트와 무관합니다.
Out of Scope Changes check ✅ Passed MyBookmarkCard 컴포넌트의 닉네임 텍스트 형식 변경만 포함되어 있으며, 모든 변경사항이 이슈 #299 범위 내입니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/#299/design-detail

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Mar 7, 2026

Copy link
Copy Markdown

✅ Storybook chromatic 배포 확인:
🐿️ storybook

@jjangminii
jjangminii merged commit c1518e0 into develop Mar 7, 2026
11 checks passed

This branch was successfully deployed

2 active deployments
Preview – pinback-client-client — bcee76b9 Deployed Mar 7, 2026 by vercel[bot]
Preview – pinback-client-landing — bcee76b9 Deployed Mar 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat 기능 개발하라 개발 달려라 달려

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] 디자인 디테일 수정

1 participant