piscsi-web: enumerate files in shared dir for CD-ROM generation - #1778
Merged
Merged
Conversation
rdmark
force-pushed
the
iso-from-shared
branch
from
September 6, 2026 08:36
acd091d to
be1d822
Compare
instead of enumerating the images dir for the dropdown where you select a file to create a CD-ROM image from, provide a list of all files in the root of the shared dir, typically /var/lib/piscsi/shared this is preferable since 1) the images dir enumerating logic filters by valid image or archive file types, and 2) conceptually the files under images are typically not used directly on host machines, while the ones in the shared dir are meant to be transferred to a host machine for users the workflow changes slightly: when uploading a file meant for an iso image, choose the shared dir instead of the images dir
rdmark
force-pushed
the
iso-from-shared
branch
4 times, most recently
from
September 6, 2026 09:37
16b016a to
86a929b
Compare
rdmark
force-pushed
the
iso-from-shared
branch
from
September 6, 2026 10:18
86a929b to
999996b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of enumerating the images dir for the dropdown where you select a file to create a CD-ROM image from, provide a list of all files in the root of the shared dir, typically /var/lib/piscsi/shared
this is preferable since 1) the images dir enumerating logic filters by valid image or archive file types, and 2) conceptually the files under images are typically not used directly on host machines, while the ones in the shared dir are meant to be transferred to a host machine
for users the workflow changes slightly: when uploading a file meant for an iso image, choose the shared dir instead of the images dir
additional piscsi-web improvements:
build and CI improvements: