Conversation
Infer the length of otherwise unsupported standard SCSI CDBs from their command group, so the target consumes the complete command before returning an invalid-command status. This prevents commands such as READ DISC INFORMATION from leaving trailing CDB bytes on the bus, while preserving the special Atari ICD prefix and rejecting vendor-specific groups whose length is not defined. Handle page-zero MODE SENSE requests as header-and-block-descriptor responses with correct MODE DATA LENGTH fields. Accept descriptor-only CD-ROM MODE SELECT requests, validate the requested logical block size, switch between the supported 512 and 2048 byte formats while preserving capacity, and rebuild CD tracking and cache state. Add unit test coverage for CDB group lengths, MODE SENSE page zero, descriptor-only MODE SELECT, and CD block-size transitions. Thank you to Jan-Benedict Glaw (@jbglaw) for the report
rdmark
force-pushed
the
1634-issues-with-simulated-dec-rrd42-scsi-drive---netbsd-on-vax-and-alpha
branch
from
September 6, 2026 06:28
7efd674 to
3df5345
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infer the length of otherwise unsupported standard SCSI CDBs from their command group, so the target consumes the complete command before returning an invalid-command status. This prevents commands such as READ DISC INFORMATION from leaving trailing CDB bytes on the bus, while preserving the special Atari ICD prefix and rejecting vendor-specific groups whose length is not defined.
Handle page-zero MODE SENSE requests as header-and-block-descriptor responses with correct MODE DATA LENGTH fields. Accept descriptor-only CD-ROM MODE SELECT requests, validate the requested logical block size, switch between the supported 512 and 2048 byte formats while preserving capacity, and rebuild CD tracking and cache state.
Add unit test coverage for CDB group lengths, MODE SENSE page zero, descriptor-only MODE SELECT, and CD block-size transitions.
Thank you to Jan-Benedict Glaw (@jbglaw) for the report