harden piscsi-web and flag safe code to SonarQube - #1775
Merged
Merged
Conversation
rdmark
force-pushed
the
go-code-quality
branch
from
September 3, 2026 04:49
af1ac5c to
561fb4b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this hardens the piscsi-web configuration file download and systemd log viewer hardening -- we now have a hard limit of 1000 lines of syslog to prevent bad outcomes
bind explicit PATH env variables in the systemd units for piscsi and piscsi-web to harden programmatic system shell calls
add or tweak a number of NOSONAR code comments to suppress false positives by the SonarQube scanner