Repository navigation
fix(e2e): retry public Solana devnet 429s in swig setup - #29
Draft
PhilBot402 wants to merge 2 commits into
Draft
PhilBot402 wants to merge 2 commits into
PhilBot402 wants to merge 2 commits into
Conversation
Public devnet returns HTTP 429 during Swig funding when SVM_TESTNET_RPC_URL is unset. swig-setup treated that as fatal, so the e2e job died after the account was created. Co-authored-by: phdargen <29732335+phdargen@users.noreply.github.com>
Keep the HTTP 429 backoff in the setup script and drop the helper module and tests. Co-authored-by: phdargen <29732335+phdargen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scheduled e2e dies in
pnpm swig:setupafter the Swig account and its USDC ATA are created. The job log showsRPC: https://api.devnet.solana.comand thenHTTP error (429): Too Many Requestson the funding transfer.SVM_TESTNET_RPC_URLis already copied toSVM_RPC_URLwhen the secret is non-empty (.github/workflows/e2e_tests.yml). This failure used the public devnet fallback, so the secret was empty.e2e/scripts/swig-setup.tssent the create, ATA, and fund RPC burst with no retry.@solana/kitturns that HTTP 429 intoHTTP error (429): Too Many Requestsand the process exits 1, which fails the whole e2e job.createRpcnow retries HTTP 429 on the setup transport (exponential backoff, delta-secondsRetry-Afterwhen present, capped at 30s, 6 attempts). The same request payload is sent again.The review target is the upstream PR: x402-foundation#3595
No changelog fragment: e2e script only, no SDK behavior change.
Tests
tsc --noEmitone2e/scripts/swig-setup.ts.pnpm swig:setupwithCLIENT_SVM_PRIVATE_KEYunset still exits 1 with the existing required-key error, before any RPC call.Checklist
tsc --noEmit; e2e has no prettier/eslint project)4F26A388131A63C19F2A8A4EF697020AB55A1144; GitHub shows verified only if that key is on the account)AI assistance
Most of this change was written with Cursor Grok 4.7. The diff was reviewed against the CI log and the kit HTTP error (
SOLANA_ERROR__RPC__TRANSPORT_HTTP_ERROR, status 429).