Repository navigation
fix(ts): match HTTP routes on escaped and decoded paths - #26
Closed
PhilBot402 wants to merge 1 commit into
Closed
PhilBot402 wants to merge 1 commit into
PhilBot402 wants to merge 1 commit into
Conversation
Literal protected routes could be reached unpaid when a request encoded its path separator. Adapters now pass the framework decoded view and getRouteConfig requires payment if either representation matches. Co-authored-by: phdargen <phdargen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of x402-foundation#3502 from Python to TypeScript SDK.
TypeScript HTTP resource servers matched protected routes against
pathonly. Python now also matchesdecoded_path, so a literal route such asGET /api/premiumcannot be reached unpaid when the framework dispatches/api%2Fpremiumas/api/premium. This port adds optionalHTTPRequestContext.decodedPathandnormalizeDecodedPath, andgetRouteConfigrequires payment if either representation matches. Express, Hono, Fastify, and Next pass that decoded view. See tracking issue x402-foundation#3541. This PR does not close it because the Go SDK is handled separately.AI disclosure: Automated by @phdargen. Use your own judgement