Repository navigation
fix(go): decode routeTemplate to a fixed point before traversal checks - #19
Closed
PhilBot402 wants to merge 2 commits into
Closed
PhilBot402 wants to merge 2 commits into
PhilBot402 wants to merge 2 commits into
Conversation
Single-pass PathUnescape lets %252e%252e slip past traversal checks. These cases lock the intended reject behavior before the decode loop. Co-authored-by: phdargen <phdargen@users.noreply.github.com>
isValidRouteTemplate used one PathUnescape pass, so double- and deeper- encoded payloads stayed percent-encoded and bypassed .. and :// checks. Decode until a fixed point or a 5-pass budget, matching TypeScript x402-foundation#3213. Co-authored-by: phdargen <phdargen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of x402-foundation#3213 from TypeScript to Go SDK.
Go
isValidRouteTemplatedecoded a routeTemplate with a single PathUnescape pass before checking for..and://. Because the charset regex allows%, a double-encoded payload such as%252e%252esurvived one decode still percent-encoded and was accepted. That lets a client poison the facilitator catalog with an arbitrary URL. This ports the TypeScript fixed-point decode (bounded to 5 PathUnescape passes) and the matching regression tests. Related to x402-foundation#3439. TypeScript and Python are unchanged.AI disclosure: Automated by @phdargen. Use your own judgement