Repository navigation
feat(sdk-release-finalize): reconcile release metadata - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk-release-finalizenow behaves as an idempotent reconciliation workflow for SDK release metadata after package publishing succeeds.Changes & impact
SDK release jobs can now depend on a single
finalizedoutput after the workflow verifies the SDK version release/tag, originGitCommit tag, and Fern replay generation tag where applicable.Details
tagNameand tag target before being accepted.create-origin-tagandpreserve-fern-generationallow narrower repair paths while preserving current defaults.Testing
actionlint .github/workflows/sdk-release-finalize.yml🤖 Generated with Claude Code
Note
Medium Risk
Changes post-publish git tagging and GitHub release validation used across SDK repos; misconfiguration could block or incorrectly accept releases, though defaults preserve prior behavior.
Overview
sdk-release-finalizeis reframed as an idempotent reconciliation workflow safe to rerun after a successful publish, a prior finalize failure, or when only some tags need repair.Callers get a new
finalizedoutput set only after a Verify finalized release state step confirms the SDK version tag (and GitHub release when enabled), origin tag, and Fern replay generation tag (when applicable) exist and point at the expected commits. Existing GitHub releases are no longer accepted on name alone—the step checkstagNamematches the version tag and that the git tag exists at the release target.create-origin-tagandpreserve-fern-generation(default true) gate origin and Fern tag work so callers can run narrower repair paths.origin-commit/origin-tagare optional at the workflow boundary (empty default) and are required only whencreate-origin-tagis true. Step names and README text now describe “ensure” / reconcile behavior instead of one-shot creation.Reviewed by Cursor Bugbot for commit ea00027. Bugbot is set up for automated code reviews on this repo. Configure here.