Repository navigation
SDK regeneration - #232
Open
fern-api[bot] wants to merge 5 commits into
Open
SDK regeneration#232fern-api[bot] wants to merge 5 commits into
fern-api[bot] wants to merge 5 commits into
Conversation
Generated by Fern CLI Version: unknown Generators: - fernapi/fern-java-sdk: 4.21.1
🌿 Generated with Fern
🌿 Generated with Fern
…dd6c4ac2d33ac3cb [skip ci]
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d73e02. Configure here.
| .addPathSegments("items"); | ||
| FileStream fs = new FileStream(stream, filename, null); | ||
| MultipartBody.Builder multipartBodyBuilder = new MultipartBody.Builder().setType(MultipartBody.FORM); | ||
| multipartBodyBuilder.addFormDataPart("file", filename, fs.toRequestBody()); |
There was a problem hiding this comment.
Stream upload drops required fields
Medium Severity
The InputStream uploadItem overloads send only the file part and ignore the file argument. They also have no way to attach document, create, request_id, or id, even though the API requires exactly one of document or create. Stream uploads therefore cannot satisfy the contract and fail at the server.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1d73e02. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
17.13.0 → 17.13.1
🌿 Generated with Fern
Note
Medium Risk
Large generated API surface changes (new batch client, expanded OMOP response shape, OAuth builder removal) can break compile-time callers and runtime parsing if they assumed older fields or
grantTypecustomization.Overview
Regenerates the Phenoml Java SDK to 17.13.1 (Fern Java SDK 4.21.1) from an updated API spec, with version/metadata and docs (
reference.md,code-examples.json) aligned to the new surface.Adds
client.lang2FhirBatch()for asynchronous Lang2FHIR jobs: create/list jobs, multipart item upload, finalize/cancel, paginated status/results, and per-item result fetch.Expands FHIR→OMOP (
fhir2Omop) in types and Javadoc: broader resource coverage (administrative/provider/location tables, derivedobservation_period), richer response metadata (diagnostics,provider_role_contexts, mapping status enums), and updated row/request fields (e.g. supported resource list onCreateOmopRequest,condition_end_datetime).Lang2FHIR multi/document requests gain optional
primaryPatient;patientReferenceremains as a deprecated alias forprimary_patient.identifieronly. Document APIs document RTF and XML/C-CDA (dedicated-instance) alongside PDF/images; create flows add resource enum values such asfamilymemberhistoryandmedicationstatement.FHIR customization APIs add implementation guide package versions (
createVersion,getVersion) and aprofiles().versions()sub-client (list/create/get/delete retained StructureDefinition versions), with updated delete/update semantics in docs.Client ergonomics:
PhenomlClient/AsyncPhenomlClientimplementAutoCloseableviaClientOptions.close()(OkHttp shutdown when the SDK owns the client). Credential auth drops configurablegrantType(alwaysclient_credentials). CustominstanceUrlno longer overwrites a non-defaultEnvironment.Reviewed by Cursor Bugbot for commit 1d73e02. Bugbot is set up for automated code reviews on this repo. Configure here.