PS-10483 - Bump molecule version - #4354
Open
tplavcic wants to merge 17 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Jenkins shared-library “install molecule” helpers used by multiple package-testing pipelines, aligning them with a newer Molecule/Ansible toolchain intended for Debian Bookworm-based test runs.
Changes:
- Bumps Molecule from
3.3.0to26.6.0and replacesmolecule-ec2withmolecule-plugins[ec2]. - Pins a newer Ansible toolchain (
ansible,ansible-core,ansible-lint) and modernizes related Python dependencies (PyYAML/pytest/pytest-testinfra/boto3). - Refactors pip installs into a single multi-line
python -m pip install ...command for readability/consistency across installers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vars/installMoleculeBookwormPXBPRO.groovy | Updates the Molecule/Ansible/Python dependency set for the PXBPRO Bookworm installer. |
| vars/installMoleculeBookworm.groovy | Updates pinned Molecule/Ansible/Python dependencies for the Bookworm installer. |
| vars/installMoleculeBookworm_pdps.groovy | Updates pinned Molecule/Ansible/Python dependencies for the pdps Bookworm installer. |
| vars/installMolecule.groovy | Updates the default Molecule install helper to the newer pinned toolchain. |
| pxc/jenkins/proxysql-package-testing-molecule.groovy | Updates the inline Molecule installer used by the ProxySQL package-testing pipeline. |
| ps/jenkins/ps-package-testing-molecule.groovy | Updates the inline Molecule installer used by the PS package-testing pipeline (also installs jq/git/unzip). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated no new comments.
Suppressed comments (3)
pxc/jenkins/pxc-keyring-test-pkgs.groovy:275
- After
installMoleculeBookwormMysql()this stage runs anotherapt updateand re-installsgit unzip jqeven though the installer already does that. This adds redundant work and time; onlyansibleappears to be needed here outside the venv.
sudo apt update -y
sudo apt install -y git unzip jq ansible
vars/installMoleculeBookwormPXBPRO.groovy:19
installMoleculeBookwormMysqlinstalls the same pinned Molecule/Ansible toolchain as other Bookworm installers (e.g.installMoleculeBookwormPXBPRO,installMoleculeBookworm_pdps). With the version list duplicated across multiplevars/steps, keeping them in sync will be error-prone; consider extracting the shared package list into a single helper (or a common installer with parameters for venv location) and calling it from the product-specific wrappers.
python -m pip install \
"molecule==26.6.0" \
"molecule-plugins[ec2]==26.7.15" \
"ansible==9.13.0" \
"ansible-core==2.16.19" \
"ansible-lint==26.6.0" \
"PyYAML==6.0.3" \
"pytest==9.1.1" \
"pytest-testinfra==10.2.2" \
"boto3==1.43.53" \
"botocore==1.43.53"
vars/installMoleculeBookwormMysql.groovy:1
- The new shared-library step name
installMoleculeBookwormMysql()is now used by several non-MySQL pipelines (PXC/PXB/ProxySQL/prel, etc.). This makes the name misleading and increases the chance of future misuse; consider renaming to something product-agnostic (e.g.installMoleculeBookworm/installMoleculeBookwormCommon) and keeping a compatibility wrapper for existing callers.
def call() {
tplavcic
marked this pull request as ready for review
August 21, 2026 08:31
tplavcic
requested review from
a team,
kaushikpuneet07,
mchawla16,
mohitj1988 and
panchal-yash
as code owners
August 21, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding PR in package-testing repo: Percona-QA/package-testing#1199