Repository navigation
New place in BidRequest & TS enabled - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Moves Allegro’s inventory extension to the OpenRTB request root and adds TypeScript support for bidder parameters.
Changes:
- Relocates the Allegro DSP extension and updates unit tests.
- Adds
AllegroBidRequestParamstyping. - Updates adapter documentation.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
modules/allegroBidAdapter.js |
Moves the inventory extension and applies parameter typing. |
modules/allegroBidAdapter.d.ts |
Defines the public bidder parameter interface. |
modules/allegroBidAdapter.md |
Documents the new extension location. |
test/spec/modules/allegroBidAdapter_spec.js |
Updates assertions for the new request structure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information