Update naming for diagnostics codes and add last Send/Reply diagnostic

Author: jpalac

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsConfigurationAnalyzerTests.cs

@@ -163,10 +163,13 @@ public Task DiagnosticIsReportedForRouteReplyToThisInstance()
 using System.Threading.Tasks; 
 class Foo
 {{
-    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
+    void Bar()
     {{
         var replyOptions = new ReplyOptions();
         [|replyOptions.RouteReplyToThisInstance()|];
+
+        var sendOptions = new SendOptions();
+        [|sendOptions.RouteReplyToThisInstance()|];
     }}
 }}";
 
@@ -182,7 +185,7 @@ public Task DiagnosticIsReportedForRouteToThisInstance()
 using System.Threading.Tasks; 
 class Foo
 {{
-    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
+    void Bar()
     {{
         var options = new SendOptions();
         [|options.RouteToThisInstance()|];
@@ -191,5 +194,27 @@ void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
 
             return Assert(AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowedId, source);
         }
+
+        [Test]
+        public Task DiagnosticIsReportedForRouteReplyToAnyInstance()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar()
+    {{
+        var options = new SendOptions();
+        [|options.RouteReplyToAnyInstance()|];
+
+        var replyOptions = new ReplyOptions();
+        [|replyOptions.RouteReplyToAnyInstance()|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.RouteReplyToAnyInstanceNotAllowedId, source);
+        }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsConfigurationAnalyzer.cs

@@ -20,7 +20,8 @@ public class AzureFunctionsConfigurationAnalyzer : DiagnosticAnalyzer
             AzureFunctionsDiagnostics.UseTransportNotAllowed,
             AzureFunctionsDiagnostics.OverrideLocalAddressNotAllowed,
             AzureFunctionsDiagnostics.RouteReplyToThisInstanceNotAllowed,
-            AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowed
+            AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowed,
+            AzureFunctionsDiagnostics.RouteReplyToAnyInstanceNotAllowed
         );
 
         static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedEndpointConfigurationMethods
@@ -39,7 +40,8 @@ static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedSendAndReplyO
             = new Dictionary<string, DiagnosticDescriptor>
             {
                 ["RouteReplyToThisInstance"] = AzureFunctionsDiagnostics.RouteReplyToThisInstanceNotAllowed,
-                ["RouteToThisInstance"] = AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowed
+                ["RouteToThisInstance"] = AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowed,
+                ["RouteReplyToAnyInstance"] = AzureFunctionsDiagnostics.RouteReplyToAnyInstanceNotAllowed
             };
 
         public override void Initialize(AnalysisContext context)

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsDiagnostics.cs

@@ -4,15 +4,16 @@
 
     public static class AzureFunctionsDiagnostics
     {
-        public const string PurgeOnStartupNotAllowedId = "NSBAF0001";
-        public const string LimitMessageProcessingToNotAllowedId = "NSBAF0002";
-        public const string DefineCriticalErrorActionNotAllowedId = "NSBAF0003";
-        public const string SetDiagnosticsPathNotAllowedId = "NSBAF0004";
-        public const string MakeInstanceUniquelyAddressableNotAllowedId = "NSBAF0005";
-        public const string UseTransportNotAllowedId = "NSBAF0006";
-        public const string OverrideLocalAddressNotAllowedId = "NSBAF0007";
-        public const string RouteReplyToThisInstanceNotAllowedId = "NSBAF0008";
-        public const string RouteToThisInstanceNotAllowedId = "NSBAF0009";
+        public const string PurgeOnStartupNotAllowedId = "NSBFUNC003";
+        public const string LimitMessageProcessingToNotAllowedId = "NSBFUNC004";
+        public const string DefineCriticalErrorActionNotAllowedId = "NSBFUNC005";
+        public const string SetDiagnosticsPathNotAllowedId = "NSBFUNC006";
+        public const string MakeInstanceUniquelyAddressableNotAllowedId = "NSBFUNC007";
+        public const string UseTransportNotAllowedId = "NSBFUNC008";
+        public const string OverrideLocalAddressNotAllowedId = "NSBFUNC009";
+        public const string RouteReplyToThisInstanceNotAllowedId = "NSBFUNC010";
+        public const string RouteToThisInstanceNotAllowedId = "NSBFUNC011";
+        public const string RouteReplyToAnyInstanceNotAllowedId = "NSBFUNC012";
 
         const string DiagnosticCategory = "NServiceBus.AzureFunctions";
 
@@ -82,7 +83,7 @@ public static class AzureFunctionsDiagnostics
         internal static readonly DiagnosticDescriptor RouteReplyToThisInstanceNotAllowed = new DiagnosticDescriptor(
              id: RouteReplyToThisInstanceNotAllowedId,
              title: "RouteReplyToThisInstance is not supported in Azure Functions",
-             messageFormat: "Azure Functions endpoints do not control the message receiver and cannot configure receiver routing.",
+             messageFormat: "Azure Functions endpoints do not control the message receiver and cannot configure specific instance routing.",
              category: DiagnosticCategory,
              defaultSeverity: DiagnosticSeverity.Error,
              isEnabledByDefault: true
@@ -91,10 +92,19 @@ public static class AzureFunctionsDiagnostics
         internal static readonly DiagnosticDescriptor RouteToThisInstanceNotAllowed = new DiagnosticDescriptor(
              id: RouteToThisInstanceNotAllowedId,
              title: "RouteToThisInstance is not supported in Azure Functions",
-             messageFormat: "Azure Functions endpoints do not control the message receiver and cannot configure receiver routing.",
+             messageFormat: "Azure Functions endpoints do not control the message receiver and cannot configure specific instance routing.",
              category: DiagnosticCategory,
              defaultSeverity: DiagnosticSeverity.Error,
              isEnabledByDefault: true
             );
+
+        internal static readonly DiagnosticDescriptor RouteReplyToAnyInstanceNotAllowed = new DiagnosticDescriptor(
+             id: RouteReplyToAnyInstanceNotAllowedId,
+             title: "RouteReplyToAnyInstance is not supported in Azure Functions",
+             messageFormat: "Azure Functions endpoints do not control the message receiver and by default route the replies to any instance.",
+             category: DiagnosticCategory,
+             defaultSeverity: DiagnosticSeverity.Warning,
+             isEnabledByDefault: true
+            );
     }
 }