send and reply options

Author: jpalac

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsConfigurationAnalyzerTests.cs

@@ -153,5 +153,43 @@ void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
 
             return Assert(AzureFunctionsDiagnostics.OverrideLocalAddressNotAllowedId, source);
         }
+
+        [Test]
+        public Task DiagnosticIsReportedForRouteReplyToThisInstance()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
+    {{
+        var replyOptions = new ReplyOptions();
+        [|replyOptions.RouteReplyToThisInstance()|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.RouteReplyToThisInstanceNotAllowedId, source);
+        }
+
+        [Test]
+        public Task DiagnosticIsReportedForRouteToThisInstance()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
+    {{
+        var options = new SendOptions();
+        [|options.RouteToThisInstance()|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowedId, source);
+        }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsConfigurationAnalyzer.cs

@@ -18,7 +18,9 @@ public class AzureFunctionsConfigurationAnalyzer : DiagnosticAnalyzer
             AzureFunctionsDiagnostics.SetDiagnosticsPathNotAllowed,
             AzureFunctionsDiagnostics.MakeInstanceUniquelyAddressableNotAllowed,
             AzureFunctionsDiagnostics.UseTransportNotAllowed,
-            AzureFunctionsDiagnostics.OverrideLocalAddressNotAllowed
+            AzureFunctionsDiagnostics.OverrideLocalAddressNotAllowed,
+            AzureFunctionsDiagnostics.RouteReplyToThisInstanceNotAllowed,
+            AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowed
         );
 
         static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedEndpointConfigurationMethods
@@ -33,6 +35,12 @@ static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedEndpointConfi
                 ["OverrideLocalAddress"] = AzureFunctionsDiagnostics.OverrideLocalAddressNotAllowed,
             };
 
+        static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedSendAndReplyOptions
+            = new Dictionary<string, DiagnosticDescriptor>
+            {
+                ["RouteReplyToThisInstance"] = AzureFunctionsDiagnostics.RouteReplyToThisInstanceNotAllowed,
+                ["RouteToThisInstance"] = AzureFunctionsDiagnostics.RouteToThisInstanceNotAllowed
+            };
 
         public override void Initialize(AnalysisContext context)
         {
@@ -53,6 +61,13 @@ static void Analyze(SyntaxNodeAnalysisContext context)
                 return;
             }
 
+            AnalyzeEndpointConfiguration(context, invocationExpression, memberAccessExpression);
+
+            AnalyzeSendAndReplyOptions(context, invocationExpression, memberAccessExpression);
+        }
+
+        static void AnalyzeEndpointConfiguration(SyntaxNodeAnalysisContext context, InvocationExpressionSyntax invocationExpression, MemberAccessExpressionSyntax memberAccessExpression)
+        {
             if (!NotAllowedEndpointConfigurationMethods.TryGetValue(memberAccessExpression.Name.Identifier.Text, out var diagnosticDescriptor))
             {
                 return;
@@ -70,5 +85,25 @@ static void Analyze(SyntaxNodeAnalysisContext context)
                 context.ReportDiagnostic(diagnosticDescriptor, invocationExpression);
             }
         }
+
+        static void AnalyzeSendAndReplyOptions(SyntaxNodeAnalysisContext context, InvocationExpressionSyntax invocationExpression, MemberAccessExpressionSyntax memberAccessExpression)
+        {
+            if (!NotAllowedSendAndReplyOptions.TryGetValue(memberAccessExpression.Name.Identifier.Text, out var diagnosticDescriptor))
+            {
+                return;
+            }
+
+            var memberAccessSymbol = context.SemanticModel.GetSymbolInfo(memberAccessExpression, context.CancellationToken);
+
+            if (!(memberAccessSymbol.Symbol is IMethodSymbol methodSymbol))
+            {
+                return;
+            }
+
+            if (methodSymbol.ReceiverType.ToString() == "NServiceBus.SendOptions" || methodSymbol.ReceiverType.ToString() == "NServiceBus.ReplyOptions")
+            {
+                context.ReportDiagnostic(diagnosticDescriptor, invocationExpression);
+            }
+        }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsDiagnostics.cs

@@ -11,6 +11,8 @@ public static class AzureFunctionsDiagnostics
         public const string MakeInstanceUniquelyAddressableNotAllowedId = "NSBAF0005";
         public const string UseTransportNotAllowedId = "NSBAF0006";
         public const string OverrideLocalAddressNotAllowedId = "NSBAF0007";
+        public const string RouteReplyToThisInstanceNotAllowedId = "NSBAF0008";
+        public const string RouteToThisInstanceNotAllowedId = "NSBAF0009";
 
         const string DiagnosticCategory = "NServiceBus.AzureFunctions";
 
@@ -76,5 +78,23 @@ public static class AzureFunctionsDiagnostics
              defaultSeverity: DiagnosticSeverity.Error,
              isEnabledByDefault: true
             );
+
+        internal static readonly DiagnosticDescriptor RouteReplyToThisInstanceNotAllowed = new DiagnosticDescriptor(
+             id: RouteReplyToThisInstanceNotAllowedId,
+             title: "RouteReplyToThisInstance is not supported in Azure Functions",
+             messageFormat: "Azure Functions endpoints do not control the message receiver and cannot configure receiver routing.",
+             category: DiagnosticCategory,
+             defaultSeverity: DiagnosticSeverity.Error,
+             isEnabledByDefault: true
+            );
+
+        internal static readonly DiagnosticDescriptor RouteToThisInstanceNotAllowed = new DiagnosticDescriptor(
+             id: RouteToThisInstanceNotAllowedId,
+             title: "RouteToThisInstance is not supported in Azure Functions",
+             messageFormat: "Azure Functions endpoints do not control the message receiver and cannot configure receiver routing.",
+             category: DiagnosticCategory,
+             defaultSeverity: DiagnosticSeverity.Error,
+             isEnabledByDefault: true
+            );
     }
 }