Added entityMaximumSize diagnostic

Author: jpalac

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsConfigurationAnalyzerTests.cs

@@ -218,7 +218,7 @@ void Bar()
         }
 
         [Test]
-        public Task DiagnosticIsReportedForMaxAutoLockRenewalDuration()
+        public Task DiagnosticIsReportedForPrefetchCount()
         {
             var source =
                 $@"using NServiceBus; 
@@ -228,31 +228,28 @@ class Foo
 {{
     void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
     {{
-        [|endpointConfig.Transport.MaxAutoLockRenewalDuration|] = new System.TimeSpan(0, 0, 5, 0);
+        [|endpointConfig.Transport.PrefetchCount|] = 5;
 
         var transportConfig = endpointConfig.Transport;
-        [|transportConfig.MaxAutoLockRenewalDuration|] = new System.TimeSpan(0, 0, 5, 0);
+        [|transportConfig.PrefetchCount|] = 5;
     }}
 }}";
 
-            return Assert(AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowedId, source);
+            return Assert(AzureFunctionsDiagnostics.PrefetchCountNotAllowedId, source);
         }
 
         [Test]
-        public Task DiagnosticIsReportedForPrefetchCount()
+        public Task DiagnosticIsReportedForPrefetchCountAsExtension()
         {
             var source =
                 $@"using NServiceBus; 
 using System;
 using System.Threading.Tasks; 
 class Foo
 {{
-    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
+    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
     {{
-        [|endpointConfig.Transport.PrefetchCount|] = 5;
-
-        var transportConfig = endpointConfig.Transport;
-        [|transportConfig.PrefetchCount|] = 5;
+        [|transportExtension.PrefetchCount(5)|];
     }}
 }}";
 
@@ -281,7 +278,25 @@ void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
         }
 
         [Test]
-        public Task DiagnosticIsReportedForTimeToWaitBeforeTriggeringCircuitBreaker()
+        public Task DiagnosticIsReportedForPrefetchMultiplierAsExtension()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
+    {{
+        [|transportExtension.PrefetchMultiplier(5)|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.PrefetchMultiplierNotAllowedId, source);
+        }
+
+        [Test]
+        public Task DiagnosticIsReportedForMaxAutoLockRenewalDuration()
         {
             var source =
                 $@"using NServiceBus; 
@@ -291,18 +306,18 @@ class Foo
 {{
     void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
     {{
-        [|endpointConfig.Transport.TimeToWaitBeforeTriggeringCircuitBreaker|] = new System.TimeSpan(0, 0, 5, 0);
+        [|endpointConfig.Transport.MaxAutoLockRenewalDuration|] = new System.TimeSpan(0, 0, 5, 0);
 
         var transportConfig = endpointConfig.Transport;
-        [|transportConfig.TimeToWaitBeforeTriggeringCircuitBreaker|] = new System.TimeSpan(0, 0, 5, 0);
+        [|transportConfig.MaxAutoLockRenewalDuration|] = new System.TimeSpan(0, 0, 5, 0);
     }}
 }}";
 
-            return Assert(AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId, source);
+            return Assert(AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowedId, source);
         }
 
         [Test]
-        public Task DiagnosticIsReportedForPrefetchCountAsExtension()
+        public Task DiagnosticIsReportedForMaxAutoLockRenewalDurationAsExtension()
         {
             var source =
                 $@"using NServiceBus; 
@@ -312,33 +327,36 @@ class Foo
 {{
     void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
     {{
-        [|transportExtension.PrefetchCount(5)|];
+        [|transportExtension.MaxAutoLockRenewalDuration(new System.TimeSpan(0, 0, 5, 0))|];
     }}
 }}";
 
-            return Assert(AzureFunctionsDiagnostics.PrefetchCountNotAllowedId, source);
+            return Assert(AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowedId, source);
         }
 
         [Test]
-        public Task DiagnosticIsReportedForPrefetchMultiplierAsExtension()
+        public Task DiagnosticIsReportedForTimeToWaitBeforeTriggeringCircuitBreaker()
         {
             var source =
                 $@"using NServiceBus; 
 using System;
 using System.Threading.Tasks; 
 class Foo
 {{
-    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
+    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
     {{
-        [|transportExtension.PrefetchMultiplier(5)|];
+        [|endpointConfig.Transport.TimeToWaitBeforeTriggeringCircuitBreaker|] = new System.TimeSpan(0, 0, 5, 0);
+
+        var transportConfig = endpointConfig.Transport;
+        [|transportConfig.TimeToWaitBeforeTriggeringCircuitBreaker|] = new System.TimeSpan(0, 0, 5, 0);
     }}
 }}";
 
-            return Assert(AzureFunctionsDiagnostics.PrefetchMultiplierNotAllowedId, source);
+            return Assert(AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId, source);
         }
 
         [Test]
-        public Task DiagnosticIsReportedForMaxAutoLockRenewalDurationAsExtension()
+        public Task DiagnosticIsReportedForTimeToWaitBeforeTriggeringCircuitBreakerAsExtension()
         {
             var source =
                 $@"using NServiceBus; 
@@ -348,15 +366,36 @@ class Foo
 {{
     void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
     {{
-        [|transportExtension.MaxAutoLockRenewalDuration(new System.TimeSpan(0, 0, 5, 0))|];
+        [|transportExtension.TimeToWaitBeforeTriggeringCircuitBreaker(new System.TimeSpan(0, 0, 5, 0))|];
     }}
 }}";
 
-            return Assert(AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowedId, source);
+            return Assert(AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId, source);
         }
 
         [Test]
-        public Task DiagnosticIsReportedForTimeToWaitBeforeTriggeringCircuitBreakerAsExtension()
+        public Task DiagnosticIsReportedForEntityMaximumSize()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
+    {{
+        [|endpointConfig.Transport.EntityMaximumSize|] = 5;
+
+        var transportConfig = endpointConfig.Transport;
+        [|transportConfig.EntityMaximumSize|] = 5;
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.EntityMaximumSizeNotAllowedId, source);
+        }
+
+        [Test]
+        public Task DiagnosticIsReportedForEntityMaximumSizeAsExtension()
         {
             var source =
                 $@"using NServiceBus; 
@@ -366,11 +405,11 @@ class Foo
 {{
     void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
     {{
-        [|transportExtension.TimeToWaitBeforeTriggeringCircuitBreaker(new System.TimeSpan(0, 0, 5, 0))|];
+        [|transportExtension.EntityMaximumSize(1)|];
     }}
 }}";
 
-            return Assert(AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId, source);
+            return Assert(AzureFunctionsDiagnostics.EntityMaximumSizeNotAllowedId, source);
         }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsConfigurationAnalyzer.cs

@@ -25,7 +25,8 @@ public class AzureFunctionsConfigurationAnalyzer : DiagnosticAnalyzer
             AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowed,
             AzureFunctionsDiagnostics.PrefetchCountNotAllowed,
             AzureFunctionsDiagnostics.PrefetchMultiplierNotAllowed,
-            AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowed
+            AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowed,
+            AzureFunctionsDiagnostics.EntityMaximumSizeNotAllowed
         );
 
         static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedEndpointConfigurationMethods
@@ -54,7 +55,8 @@ static readonly Dictionary<string, DiagnosticDescriptor> NotAllowedTransportSett
                 ["MaxAutoLockRenewalDuration"] = AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowed,
                 ["PrefetchCount"] = AzureFunctionsDiagnostics.PrefetchCountNotAllowed,
                 ["PrefetchMultiplier"] = AzureFunctionsDiagnostics.PrefetchMultiplierNotAllowed,
-                ["TimeToWaitBeforeTriggeringCircuitBreaker"] = AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowed
+                ["TimeToWaitBeforeTriggeringCircuitBreaker"] = AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowed,
+                ["EntityMaximumSize"] = AzureFunctionsDiagnostics.EntityMaximumSizeNotAllowed
             };
 
         public override void Initialize(AnalysisContext context)

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsDiagnostics.cs

@@ -20,6 +20,8 @@ public static class AzureFunctionsDiagnostics
         public const string PrefetchMultiplierNotAllowedId = "NSBFUNC015";
         public const string TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId = "NSBFUNC016";
 
+        public const string EntityMaximumSizeNotAllowedId = "NSBFUNC017";
+
         const string DiagnosticCategory = "NServiceBus.AzureFunctions";
 
         internal static readonly DiagnosticDescriptor PurgeOnStartupNotAllowed = new DiagnosticDescriptor(
@@ -147,5 +149,14 @@ public static class AzureFunctionsDiagnostics
              defaultSeverity: DiagnosticSeverity.Error,
              isEnabledByDefault: true
             );
+
+        internal static readonly DiagnosticDescriptor EntityMaximumSizeNotAllowed = new DiagnosticDescriptor(
+             id: EntityMaximumSizeNotAllowedId,
+             title: "EntityMaximumSize is not supported in Azure Functions",
+             messageFormat: "Azure Functions endpoints do not support automatic queue creation.",
+             category: DiagnosticCategory,
+             defaultSeverity: DiagnosticSeverity.Error,
+             isEnabledByDefault: true
+            );
     }
 }