Added transport extension method diagnostics

Author: jpalac

src/NServiceBus.AzureFunctions.Analyzer.Tests/AzureFunctionsConfigurationAnalyzerTests.cs

@@ -300,5 +300,77 @@ void Bar(ServiceBusTriggeredEndpointConfiguration endpointConfig)
 
             return Assert(AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId, source);
         }
+
+        [Test]
+        public Task DiagnosticIsReportedForPrefetchCountAsExtension()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
+    {{
+        [|transportExtension.PrefetchCount(5)|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.PrefetchCountNotAllowedId, source);
+        }
+
+        [Test]
+        public Task DiagnosticIsReportedForPrefetchMultiplierAsExtension()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
+    {{
+        [|transportExtension.PrefetchMultiplier(5)|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.PrefetchMultiplierNotAllowedId, source);
+        }
+
+        [Test]
+        public Task DiagnosticIsReportedForMaxAutoLockRenewalDurationAsExtension()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
+    {{
+        [|transportExtension.MaxAutoLockRenewalDuration(new System.TimeSpan(0, 0, 5, 0))|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.MaxAutoLockRenewalDurationNotAllowedId, source);
+        }
+
+        [Test]
+        public Task DiagnosticIsReportedForTimeToWaitBeforeTriggeringCircuitBreakerAsExtension()
+        {
+            var source =
+                $@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
+class Foo
+{{
+    void Bar(TransportExtensions<AzureServiceBusTransport> transportExtension)
+    {{
+        [|transportExtension.TimeToWaitBeforeTriggeringCircuitBreaker(new System.TimeSpan(0, 0, 5, 0))|];
+    }}
+}}";
+
+            return Assert(AzureFunctionsDiagnostics.TimeToWaitBeforeTriggeringCircuitBreakerNotAllowedId, source);
+        }
     }
 }

src/NServiceBus.AzureFunctions.Analyzer/AzureFunctionsConfigurationAnalyzer.cs

@@ -80,6 +80,8 @@ static void Analyze(SyntaxNodeAnalysisContext context)
             AnalyzeEndpointConfiguration(context, invocationExpression, memberAccessExpression);
 
             AnalyzeSendAndReplyOptions(context, invocationExpression, memberAccessExpression);
+
+            AnalyzeTransportExtensions(context, invocationExpression, memberAccessExpression);
         }
 
         static void AnalyzeTransport(SyntaxNodeAnalysisContext context)
@@ -148,5 +150,25 @@ static void AnalyzeSendAndReplyOptions(SyntaxNodeAnalysisContext context, Invoca
                 context.ReportDiagnostic(diagnosticDescriptor, invocationExpression);
             }
         }
+
+        static void AnalyzeTransportExtensions(SyntaxNodeAnalysisContext context, InvocationExpressionSyntax invocationExpression, MemberAccessExpressionSyntax memberAccessExpression)
+        {
+            if (!NotAllowedTransportSettings.TryGetValue(memberAccessExpression.Name.Identifier.Text, out var diagnosticDescriptor))
+            {
+                return;
+            }
+
+            var memberAccessSymbol = context.SemanticModel.GetSymbolInfo(memberAccessExpression, context.CancellationToken);
+
+            if (!(memberAccessSymbol.Symbol is IMethodSymbol methodSymbol))
+            {
+                return;
+            }
+
+            if (methodSymbol.ReceiverType.ToString() == "NServiceBus.TransportExtensions<NServiceBus.AzureServiceBusTransport>")
+            {
+                context.ReportDiagnostic(diagnosticDescriptor, invocationExpression);
+            }
+        }
     }
 }