Skip to content

fix(marketing): keep the cookie banner buttons inside the box - #9194

Merged
saddlepaddle merged 1 commit into
ParadevAI:mainfrom
serhii-kucherenko:serhii/cookie-banner-wrap
Oct 31, 2026
Merged

saddlepaddle merged 1 commit into
ParadevAI:mainfrom
serhii-kucherenko:serhii/cookie-banner-wrap

Conversation

@serhii-kucherenko

@serhii-kucherenko serhii-kucherenko commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What & why

The marketing cookie banner is max-w-xs, and its action row was one justify-between line that could not wrap. In 12 of the 18 locales (cs, de, es, fr, it, ja, nl, pl, pt-BR, ru, uk, vi), "Accept" rendered past the banner's right edge.

The privacy link now takes its own line, and the two buttons share a two-column grid below it. The banner keeps one shape in every locale, and Opt-out and Accept get equal width.

Screenshots (before → after, 1280px)

Overflowed before:

cs

cs before → cs after

de

de before → de after

es

es before → es after

fr

fr before → fr after

it

it before → it after

ja

ja before → ja after

nl

nl before → nl after

pl

pl before → pl after

pt-BR

pt-BR before → pt-BR after

uk

uk before → uk after

vi

vi before → vi after

Already fit before (6): en, id, ko, tr, zh-CN, zh-TW

en

en before → en after

id

id before → id after

ko

ko before → ko after

tr

tr before → tr after

zh-CN

zh-CN before → zh-CN after

zh-TW

zh-TW before → zh-TW after

How I tested it

  • Drove the dev site in headless Chrome and checked each banner link and button against the banner's edges. At 1280px across all 18 locales: before, 12 overflow; after, none. At 320px in en, fr, uk, ja and es: no overflow after.
  • I also tried keeping one line and wrapping only when needed. I dropped it because the banner then changes shape between languages.
  • Biome passes on the changed file, and tsc passes in apps/marketing.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs
  • I have signed the CLA (the bot asks on your first PR)

Summary by cubic

Fixes the marketing cookie banner so the Accept and Opt-out buttons no longer overflow the box in 12 of 18 locales.

  • The privacy link now takes its own line, and the two buttons share a two-column grid beneath it.
  • The banner keeps one shape across all locales, with Opt-out and Accept equal width.

Written for commit 189285c. Summary will update on new commits.

View guided diff

Summary by CodeRabbit

  • Style
    • Updated the cookie consent banner layout. The privacy policy link now appears above the consent buttons, which are displayed side by side in a full-width, two-column grid. This replaces the previous single-row arrangement and creates a clearer separation between the policy information and consent choices within the banner.

The banner is max-w-xs and its action row did not wrap, so in fr, es, uk,
ja and other locales the Accept button rendered past the right edge. The
privacy link now takes its own line and the two buttons share a two-column
grid, so the banner keeps one shape in every locale.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 627b6aa0-a2b4-4520-baf6-16f8243c389b
Commits

Reviewing files that changed from the base of the PR and between 0dcd64a and 189285c.

Files selected for processing: 1
  • apps/marketing/src/components/CookieConsent/CookieConsent.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The cookie consent banner now places the privacy-policy link above the consent buttons. The buttons use a full-width, two-column grid instead of the previous single-row layout.

Changes: Cookie consent layout

Layer / File(s) Summary
Banner layout
apps/marketing/src/components/CookieConsent/CookieConsent.tsx
The privacy-policy link moves above the consent buttons. The buttons use a full-width, two-column grid.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: kitenite

Merge Risk: Minimal · up to 18928

The cookie banner layout change is ready to merge; no actionable issue remains from the reviewed scope.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title uses conventional commit format and clearly describes the main change: keeping marketing cookie-banner buttons inside the banner.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description is complete and follows the required template. It explains the problem and solution, documents testing across locales and viewport sizes, includes before-and-after screens…
Full details: Description check

Explanation

The pull request description is complete and follows the required template. It explains the problem and solution, documents testing across locales and viewport sizes, includes before-and-after screenshots, and completes the checklist.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Moves the cookie banner’s privacy link above two equal-width buttons.

  • Cookie banner choices stay inside the box in every language.

No actionable issues found. No runtime or visual checks were performed during this review.

Reviews (1) · Last reviewed commit: "fix(marketing): keep the cookie banner b..." · Reviewed by Greptile

@saddlepaddle
saddlepaddle merged commit 9e01258 into ParadevAI:main Oct 31, 2026
10 of 12 checks passed

This branch had an error being deployed

1 failed deployment
preview — 189285c7 Deployed Oct 31, 2026 by serhii-kucherenko via Create Database (Neon) #13426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants