Repository navigation
fix(marketing): keep the cookie banner buttons inside the box - #9194
Conversation
The banner is max-w-xs and its action row did not wrap, so in fr, es, uk, ja and other locales the Accept button rendered past the right edge. The privacy link now takes its own line and the two buttons share a two-column grid, so the banner keeps one shape in every locale.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Banner layout apps/marketing/src/components/CookieConsent/CookieConsent.tsx |
The privacy-policy link moves above the consent buttons. The buttons use a full-width, two-column grid. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: kitenite
Merge Risk: 
Minimal · up to 18928
-
The cookie banner layout change is ready to merge; no actionable issue remains from the reviewed scope.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The pull request description is complete and follows the required template. It explains the problem and solution, documents testing across locales and viewport sizes, includes before-and-after screenshots, and completes the checklist.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryMoves the cookie banner’s privacy link above two equal-width buttons.
No actionable issues found. No runtime or visual checks were performed during this review. Reviews (1) · Last reviewed commit: "fix(marketing): keep the cookie banner b..." · Reviewed by Greptile |
What & why
The marketing cookie banner is
max-w-xs, and its action row was onejustify-betweenline that could not wrap. In 12 of the 18 locales (cs, de, es, fr, it, ja, nl, pl, pt-BR, ru, uk, vi), "Accept" rendered past the banner's right edge.The privacy link now takes its own line, and the two buttons share a two-column grid below it. The banner keeps one shape in every locale, and Opt-out and Accept get equal width.
Screenshots (before → after, 1280px)
Overflowed before:
cs
de
es
fr
it
ja
nl
pl
pt-BR
uk
vi
Already fit before (6): en, id, ko, tr, zh-CN, zh-TW
en
id
ko
tr
zh-CN
zh-TW
How I tested it
tscpasses inapps/marketing.Checklist
type(scope): subject)bun run lintandbun run typecheckpass (CI fails on lint warnings too)Summary by cubic
Fixes the marketing cookie banner so the Accept and Opt-out buttons no longer overflow the box in 12 of 18 locales.
Written for commit 189285c. Summary will update on new commits.
Summary by CodeRabbit