Repository navigation
feat(marketing): full-screen footer with globe grid and closing CTA - #9179
Conversation
The footer now fills the viewport below the header, Pax-style: a large closing headline with the download and GitHub buttons on top, link columns and a bottom bar below. - Move CTASection into the footer so every page ends with the CTA; drop the per-page copies and the CLI install box so it fits one screen - Projected globe grid in dark lines that lights up around the cursor, reusing the EdgeGlare pointer hook (promoted to app/[lang]/hooks) - Split Product links into two columns and compress spacing on short viewports so 1280x720 through 1920x1080 fit exactly - Legal links move to a bottom bar with the copyright and language switcher - New headline "Smash your backlog." translated for all locales
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No installed development build can load this pull request as an update: its native fingerprint is |
[Medium impact] The changes affect the shared marketing footer across localized marketing pages. The PR appears safe to merge, with a non-blocking waitlist backdrop issue. Findings
Fix with agent prompt### Issue 1
apps/marketing/src/app/[lang]/components/Footer/Footer.tsx:201
The new `isolate` on the footer puts its `WaitlistModal` below the sticky `Header`. When a Windows visitor clicks “Join Waitlist,” the header stays visible and clickable above the full-screen backdrop. The modal renders directly inside the footer, so its `z-50` cannot rise above the footer’s own layer. Render the modal through a portal outside the footer.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryMoves the closing CTA into the shared footer and adds a mouse-lit globe backdrop.
Reviews (1) · Last reviewed commit: "feat(marketing): full-screen footer with..." · Reviewed by Greptile |
|
|
||
| return ( | ||
| <footer className="border-t border-border bg-background"> | ||
| <footer className="relative isolate flex min-h-[calc(100svh-4rem)] flex-col overflow-hidden border-t border-border bg-background"> |
There was a problem hiding this comment.
The new isolate on the footer puts its WaitlistModal below the sticky Header. When a Windows visitor clicks “Join Waitlist,” the header stays visible and clickable above the full-screen backdrop. The modal renders directly inside the footer, so its z-50 cannot rise above the footer’s own layer. Render the modal through a portal outside the footer.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/marketing/src/app/[lang]/components/Footer/Footer.tsx
Line: 201
Comment:
**Header stays above waitlist**
The new `isolate` on the footer puts its `WaitlistModal` below the sticky `Header`. When a Windows visitor clicks “Join Waitlist,” the header stays visible and clickable above the full-screen backdrop. The modal renders directly inside the footer, so its `z-50` cannot rise above the footer’s own layer. Render the modal through a portal outside the footer.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
What
The marketing footer now fills the screen below the header, modeled on paxai.com:
CTASectionmoved intoFooter/components/, so every page ends with it. The per-page copies (home, automations, browser, pages, plugins, team) are removed so it doesn't show twice. The CLI install box is dropped so the footer fits on one screen.EdgeGlare.usePointerVarsis promoted toapp/[lang]/hooks/because two components now share it. Mouse only, so touch devices see just the dark grid.Verification
jalocale at 1440.tsc --noEmit, biome,bun run check:i18n(0 missing in every locale) and the marketingbun testsuite (201 pass) all pass.Summary by cubic
The marketing footer now fills the screen below the header with the closing CTA and a projected globe grid backdrop.
Written for commit 339ca63. Summary will update on new commits.