feat(host-service,desktop): GitLab MR discussions, job logs, PR pane and workspace from MR

apps/desktop/src/renderer/lib/github/openPullRequestLink/openPullRequestLink.test.ts

@@ -13,8 +13,8 @@ function open(url: string, action: LinkAction | null) {
 }
 
 describe("openPullRequestLink", () => {
-	it("opens a URL that is not a GitHub pull request in the browser", () => {
-		const url = "https://gitlab.com/acme/app/-/merge_requests/3";
+	it("opens a URL that is not a pull request in the browser", () => {
+		const url = "https://gitlab.com/acme/app/-/issues/3";
 		const { openPane, openInBrowser } = open(url, "pane");
 		expect(openInBrowser).toHaveBeenCalledWith(url);
 		expect(openPane).not.toHaveBeenCalled();
@@ -38,6 +38,13 @@ describe("openPullRequestLink", () => {
 		expect(openInBrowser).not.toHaveBeenCalled();
 	});
 
+	it("splits the pull request pane for a GitLab merge request", () => {
+		const url = "https://gitlab.com/acme/sub/app/-/merge_requests/3";
+		const { openPane } = open(url, "pane");
+		const ref = { repoFullName: "gitlab.com/acme/sub/app", number: 3 };
+		expect(openPane).toHaveBeenCalledWith(ref, "split");
+	});
+
 	it("falls back to the split pane for an unbound tier", () => {
 		const { openPane, openInBrowser } = open(PR_URL, null);
 		expect(openPane).toHaveBeenCalledWith(PR_REF, "split");

apps/desktop/src/renderer/lib/github/pullRequestRef.ts

@@ -7,8 +7,12 @@ export interface PullRequestRef {
 const PULL_REQUEST_URL =
 	/^https:\/\/github\.com\/([^/?#]+\/[^/?#]+)\/pull\/(\d+)(?:[/?#]|$)/;
 
+// A GitLab MR keeps its host in the name, so it never reads as a GitHub repo.
+const MERGE_REQUEST_URL =
+	/^https:\/\/([^/?#]+\/[^?#]+?)\/-\/merge_requests\/(\d+)(?:[/?#]|$)/;
+
 export function pullRequestRefFromUrl(url: string): PullRequestRef | null {
-	const match = PULL_REQUEST_URL.exec(url);
+	const match = PULL_REQUEST_URL.exec(url) ?? MERGE_REQUEST_URL.exec(url);
 	if (!match?.[1] || !match[2]) return null;
 	return { repoFullName: match[1], number: Number(match[2]) };
 }

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/ChangesControl/components/PRStatusGroup/PRStatusGroup.tsx

@@ -445,7 +445,7 @@ export function PRStatusGroup({
 							<DropdownMenuItem asChild className={menuItemClass}>
 								<a href={pr.url} target="_blank" rel="noopener noreferrer">
 									<LuArrowUpRight className={menuIconClass} />
-									<Trans>View on GitHub</Trans>
+									<Trans>Open in browser</Trans>
 								</a>
 							</DropdownMenuItem>
 						</DropdownMenuContent>

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/ChangesControl/components/PRStatusGroup/components/PRDetailCard/PRDetailCard.tsx

@@ -96,7 +96,7 @@ export function PRDetailCard({ pr, checks, linkState }: PRDetailCardProps) {
 				className="group flex items-center justify-between border-t border-border/60 px-3 py-2 text-[11px] font-medium text-muted-foreground transition-colors hover:bg-accent hover:text-foreground"
 			>
 				<span>
-					<Trans>View on GitHub</Trans>
+					<Trans>Open in browser</Trans>
 				</span>
 				<LuArrowUpRight
 					aria-hidden="true"

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/WorkspaceSidebar/hooks/useReviewTab/components/ChecksSection/ChecksSection.tsx

@@ -144,14 +144,15 @@ function CheckRow({
 }) {
 	const { Icon: CheckIcon, className } = CHECK_STATUS_ICONS[check.status];
 	const checkUrl = resolveCheckUrl(check, prUrl);
-	// Mirror the server's guard: only failed github.com Actions job URLs have
-	// downloadable logs, so don't offer copy for non-GitHub CI checks.
+	// Mirror the server's guard: only failed GitHub Actions and GitLab CI job
+	// URLs have downloadable logs, so don't offer copy for other checks.
 	const canCopyLogs =
 		check.status === "failure" &&
 		!!check.url &&
 		URL.canParse(check.url) &&
-		new URL(check.url).hostname === "github.com" &&
-		/\/job\/\d+/.test(check.url);
+		((new URL(check.url).hostname === "github.com" &&
+			/\/job\/\d+/.test(check.url)) ||
+			/\/-\/jobs\/\d+/.test(check.url));
 
 	const rowContent = (
 		<div className="flex min-w-0 flex-1 items-center gap-1 rounded-sm px-1.5 py-1 text-xs transition-colors hover:bg-accent/50">

packages/host-service/src/runtime/pull-requests/pull-requests.test.ts

@@ -149,6 +149,7 @@ function createManager(
 	db: HostDb,
 	overrides: {
 		execGh?: (args: string[]) => Promise<unknown>;
+		execGlab?: (args: string[]) => Promise<unknown>;
 		github?: () => Promise<never>;
 		git?: unknown;
 		readWorkspaceRefs?: (
@@ -174,6 +175,7 @@ function createManager(
 			((async () => {
 				throw new Error("octokit should not be used");
 			}) as never),
+		execGlab: overrides.execGlab as never,
 		gitWatcher: { onChanged: () => () => {} } as never,
 		readWorkspaceRefs: overrides.readWorkspaceRefs,
 		// Seeded worktree paths are fabricated; default the disk gate open so
@@ -2490,3 +2492,89 @@ describe("PullRequestRuntimeManager GitHub traffic", () => {
 		expect(getWorkspace(db, "ws")?.pullRequestId).toBeNull();
 	});
 });
+
+describe("GitLab through glab", () => {
+	function gitlabProject(owner: string, answer: (args: string[]) => unknown) {
+		const db = createRealDb();
+		db.insert(schema.projects)
+			.values({ id: PROJECT_ID, repoPath: "/repo", createdAt: Date.now() })
+			.run();
+		seedWorkspace(db, {
+			id: "ws",
+			branch: "feat",
+			upstreamOwner: owner,
+			upstreamRepo: "app",
+			upstreamBranch: "feat",
+		});
+		const calls: string[][] = [];
+		const manager = createManager(db, {
+			git: async () => ({
+				remote: async () => `git@${owner.replace("/", ":")}/app.git`,
+				raw: async () => "origin/main\n",
+			}),
+			execGlab: async (args) => {
+				calls.push(args);
+				return answer(args);
+			},
+		});
+		return { db, calls, refresh: () => projectRefresher(manager)(PROJECT_ID) };
+	}
+
+	test("links a workspace to its MR with the head pipeline as its check", async () => {
+		const webUrl =
+			"https://gitlab.example.com/group/sub/app/-/merge_requests/7";
+		const glab: Record<string, unknown> = {
+			"config get": "gitlab.example.com",
+			"mr list": [
+				{
+					iid: 7,
+					web_url: webUrl,
+					state: "opened",
+					source_branch: "feat",
+					sha: "sha-1",
+					source_project_id: 1,
+					target_project_id: 1,
+				},
+			],
+			"mr view": {
+				web_url: webUrl,
+				target_project_id: 1,
+				detailed_merge_status: "not_approved",
+				head_pipeline: { id: 9 },
+			},
+			"ci get": { jobs: [{ name: "test", status: "failed" }] },
+		};
+		const { db, calls, refresh } = gitlabProject(
+			"gitlab.example.com/group/sub",
+			(args) => glab[`${args[0]} ${args[1]}`] ?? {},
+		);
+
+		await refresh();
+
+		const pr = getPrById(db, getWorkspace(db, "ws")?.pullRequestId ?? "");
+		expect(pr).toMatchObject({
+			repoProvider: "gitlab",
+			repoOwner: "gitlab.example.com/group/sub",
+			url: webUrl,
+			state: "open",
+			reviewDecision: "pending",
+			checksStatus: "failure",
+		});
+		expect(calls[1]).toContain("https://gitlab.example.com/group/sub/app");
+		expect(db.select().from(schema.projects).get()?.repoProvider).toBeNull();
+	});
+
+	test("asks glab again about an unknown host and looks up no MR", async () => {
+		const { db, calls, refresh } = gitlabProject(
+			"git.example.com/team",
+			() => ({}),
+		);
+
+		await refresh();
+		await refresh();
+
+		const ask = ["config", "get", "api_host", "--host", "git.example.com"];
+		expect(calls).toEqual([ask, ask]);
+		expect(getWorkspace(db, "ws")?.pullRequestId).toBeNull();
+	});
+});

packages/host-service/src/runtime/pull-requests/pull-requests.ts

@@ -2,6 +2,7 @@ import { randomUUID } from "node:crypto";
 import { existsSync } from "node:fs";
 import type { Octokit } from "@octokit/rest";
 import { parseGitHubRemote } from "@superset/shared/github-remote";
+import { parseGitLabRemote } from "@superset/shared/gitlab-remote";
 import { and, eq, inArray, isNull } from "drizzle-orm";
 import type { HostDb } from "../../db";
 import {
@@ -13,6 +14,10 @@ import {
 import type { EventBus } from "../../events/event-bus";
 import type { GitWatcher } from "../../events/git-watcher";
 import type { ExecGh } from "../../trpc/router/workspace-creation/utils/exec-gh";
+import {
+	type ExecGlab,
+	execGlab,
+} from "../../trpc/router/workspace-creation/utils/exec-glab";
 import { type GitFactory, resolveDefaultBranchName } from "../git";
 import { ConditionalGh } from "./utils/conditional-gh";
 import {
@@ -26,8 +31,10 @@ import {
 	fetchOpenPullRequestsFromGh,
 	fetchPullRequestByHead,
 	fetchPullRequestByHeadFromGh,
+	fetchPullRequestByHeadFromGlab,
 	fetchPullRequestChecks,
 	fetchPullRequestChecksFromGh,
+	fetchPullRequestDetailsFromGlab,
 	fetchPullRequestMergeQueueState,
 	fetchPullRequestMergeQueueStateFromGh,
 	fetchPullRequestReviewDecision,
@@ -92,7 +99,7 @@ function upstreamKey(
 	return `${owner.toLowerCase()}/${repo.toLowerCase()}#${branch}`;
 }
 
-type RepoProvider = "github";
+type RepoProvider = "github" | "gitlab";
 
 export interface PullRequestStateSnapshot {
 	url: string;
@@ -144,6 +151,7 @@ export interface PullRequestRuntimeManagerOptions {
 	execGh: ExecGh;
 	git: GitFactory;
 	github: () => Promise<Octokit>;
+	execGlab?: ExecGlab;
 	gitWatcher: GitWatcher;
 	/** Override to run the per-workspace branch/HEAD/upstream read off the
 	 * event loop (app wiring passes a worker-pool-backed reader). Defaults
@@ -223,6 +231,8 @@ export class PullRequestRuntimeManager {
 	private readonly conditionalGh: ConditionalGh;
 	private readonly git: GitFactory;
 	private readonly github: () => Promise<Octokit>;
+	private readonly execGlab: ExecGlab;
+	private readonly glabHosts = new Set<string>();
 	private readonly gitWatcher: GitWatcher;
 	private safetyNetTimer: ReturnType<typeof setInterval> | null = null;
 	private projectRefreshTimer: ReturnType<typeof setInterval> | null = null;
@@ -288,6 +298,7 @@ export class PullRequestRuntimeManager {
 		this.execGh = this.conditionalGh.exec;
 		this.git = options.git;
 		this.github = options.github;
+		this.execGlab = options.execGlab ?? execGlab;
 		this.gitWatcher = options.gitWatcher;
 		this.readWorkspaceRefs =
 			options.readWorkspaceRefs ??
@@ -1049,6 +1060,13 @@ export class PullRequestRuntimeManager {
 		}
 	}
 
+	async getGitLabRepository(
+		projectId: string,
+	): Promise<NormalizedRepoIdentity | null> {
+		const repo = await this.getProjectRepository(projectId);
+		return repo?.provider === "gitlab" ? repo : null;
+	}
+
 	private async getProjectRepository(
 		projectId: string,
 	): Promise<NormalizedRepoIdentity | null> {
@@ -1090,7 +1108,13 @@ export class PullRequestRuntimeManager {
 			}
 
 			const parsedRemote = parseGitHubRemote(remoteUrl);
-			if (!parsedRemote) return null;
+			if (!parsedRemote) {
+				// Not persisted: the rest of the app reads projects.repo* as GitHub.
+				const gitlab = parseGitLabRemote(remoteUrl);
+				if (!gitlab || !(await this.isGlabHost(gitlab))) return null;
+				const defaultBranch = await this.resolveDefaultBranch(project.repoPath);
+				return { ...gitlab, remoteName, defaultBranch };
+			}
 
 			this.db
 				.update(projects)
@@ -1111,6 +1135,23 @@ export class PullRequestRuntimeManager {
 		return { ...identity, defaultBranch };
 	}
 
+	// glab knows a host when its config has an API host for it (a local read).
+	// Only known hosts are kept, so a host added later shows at the next refresh.
+	private async isGlabHost({ owner }: { owner: string }): Promise<boolean> {
+		const host = owner.slice(0, owner.indexOf("/"));
+		if (this.glabHosts.has(host)) return true;
+		const apiHost = await this.execGlab([
+			"config",
+			"get",
+			"api_host",
+			"--host",
+			host,
+		]).catch(() => "");
+		if (typeof apiHost !== "string" || apiHost === "") return false;
+		this.glabHosts.add(host);
+		return true;
+	}
+
 	// Shared origin/HEAD resolver; a repo-open failure disables the guard
 	// rather than aborting the whole refresh.
 	private async resolveDefaultBranch(repoPath: string): Promise<string | null> {
@@ -1415,23 +1456,25 @@ export class PullRequestRuntimeManager {
 			cacheKey,
 			options,
 			() =>
-				this.fetchFromGitHub(
-					"PR head lookup",
-					{ owner: repo.owner, name: repo.name, head },
-					() =>
-						fetchPullRequestByHeadFromGh(
-							this.execGh,
-							{ owner: repo.owner, name: repo.name },
-							head,
-						),
-					async () =>
-						fetchPullRequestByHead(
-							await this.github(),
-							{ owner: repo.owner, name: repo.name },
-							head,
+				repo.provider === "gitlab"
+					? fetchPullRequestByHeadFromGlab(this.execGlab, repo, head)
+					: this.fetchFromGitHub(
+							"PR head lookup",
+							{ owner: repo.owner, name: repo.name, head },
+							() =>
+								fetchPullRequestByHeadFromGh(
+									this.execGh,
+									{ owner: repo.owner, name: repo.name },
+									head,
+								),
+							async () =>
+								fetchPullRequestByHead(
+									await this.github(),
+									{ owner: repo.owner, name: repo.name },
+									head,
+								),
+							{ probe: options.bypassCache === true },
 						),
-					{ probe: options.bypassCache === true },
-				),
 		);
 	}
 
@@ -1454,6 +1497,13 @@ export class PullRequestRuntimeManager {
 			cacheKey,
 			{ ...options, fingerprint: node.headRefOid },
 			async () => {
+				if (repo.provider === "gitlab") {
+					return fetchPullRequestDetailsFromGlab(
+						this.execGlab,
+						repo,
+						node.number,
+					);
+				}
 				const [reviewDecision, checks] = await this.fetchFromGitHub(
 					"PR review/check lookup",
 					context,
@@ -1524,6 +1574,9 @@ export class PullRequestRuntimeManager {
 		repo: NormalizedRepoIdentity,
 		options: { bypassCache?: boolean } = {},
 	): Promise<GitHubPullRequestNode[]> {
+		// No GitLab sweep yet. GitLab's branch filter is also case-sensitive, so a
+		// branch whose case drifted from its MR stays unlinked.
+		if (repo.provider === "gitlab") return [];
 		const cacheKey = `${repo.owner.toLowerCase()}/${repo.name.toLowerCase()}`;
 		return this.cachedGitHubFetch(
 			this.openPullRequestsCache,

packages/host-service/src/runtime/pull-requests/utils/github-query/github-query.test.ts → packages/host-service/src/runtime/pull-requests/utils/github-query/github-gitlab-query.test.ts

@@ -6,7 +6,7 @@ import {
 	fetchPullRequestMergeQueueStateFromGh,
 	fetchPullRequestReviewDecisionFromGh,
 	parseMergedAt,
-} from "./github-query";
+} from "./github-gitlab-query";
 
 interface GhCall {
 	args: string[];