fix: clean up CLI notice, unused dotenv dependency, and version checks - #648
Open
zacman-99 wants to merge 3 commits into
Open
fix: clean up CLI notice, unused dotenv dependency, and version checks#648zacman-99 wants to merge 3 commits into
zacman-99 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small, zero-behavioral-risk fixes from a code-review pass:
fix(cli): restore coherent twitter verification notice (
agent_reach/cli.py)The message printed after
configure twitter-cookieswas a garbled splice of twounrelated sentences. Restored one coherent notice grounded in the existing wording used
by
channels/twitter.pyanddocs/guides/setup-twitter.md. No runtime behaviorchanged beyond correcting the malformed notice.
chore(deps): drop unused python-dotenv pin (
pyproject.toml,constraints.txt)python-dotenvwas never imported anywhere in the package or tests, and no code loads.envfiles (env fallback reads liveos.environdirectly). Removed from bothdependency locations: the
pyproject.tomlruntime dependency list and theconstraints.txttested-set pin.test: add version-consistency check (
tests/test_version_consistency.py, new)Enforces the project convention that the version matches across
pyproject.toml,agent_reach/__init__.py, and the version literals referenced bytests/test_cli.py.Uses stdlib regex parsing only (no
tomllib) to stay compatible with Python 3.10.Test results
pytest tests/test_cli.py tests/test_version_consistency.py→ 28 passedruff check agent_reach/cli.py pyproject.toml constraints.txt tests/test_version_consistency.py→ cleanBranch and commits
Branch:
fix/section-7-cleanupResidual risks
literals in
tests/test_cli.py(the failure message spells this out).python-dotenvconstraint means fresh environments resolve it only if someother dependency requires it; nothing in this repo does. No installed code changes.