fix(deps): add missing mcp optional-dependency extra - #624
Open
aarochu wants to merge 1 commit into
Open
Conversation
mcp_server.py tells users to install agent-reach[mcp] when the mcp package is missing, but pyproject.toml never defined that extra, so the guidance was a dead end. Closes Panniantong#608. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_reach/integrations/mcp_server.pytells users to installagent-reach[mcp]when themcppackage is missing, butpyproject.tomlnever defined anmcpextra (onlybrowser,cookies,all,devexist). The suggested fix command was a dead end.mcp = ["mcp[cli]>=1.0"]to[project.optional-dependencies]so the guided install command actually works.Closes #608
Test plan
python -m pytest tests/ -v— same 11 pre-existing failures as onmain(Windows symlink-privilege issues + one missing test module), unrelated to this change; no new failures introduced.