fix: pip install update is a silent no-op for pipx installs (#610) - #612
Open
Pavankalyan32 wants to merge 1 commit into
Open
fix: pip install update is a silent no-op for pipx installs (#610)#612Pavankalyan32 wants to merge 1 commit into
Pavankalyan32 wants to merge 1 commit into
Conversation
…tong#610) pip install --upgrade <archive-url> updates user/system site-packages but not the pipx venv the agent-reach executable points at - silently failing with no error. Detect the install method and emit the matching command: - pipx installs: pipx upgrade agent-reach - otherwise: existing pip install --upgrade (venv case covered by the PEP 668 note) Changes: - cli.py: _detect_install_method() + _update_instructions() replacing the static _UPDATE_INSTRUCTIONS constant (check-update/watch output) - docs/update.md: Step 2 detects install method before updating - tests: cover pipx/venv/pip detection and instruction output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #610
Problem
\docs/update.md\ Step 2 and the \check-update\ output (_UPDATE_INSTRUCTIONS) tell users to run \pip install --upgrade . For pipx installs (the officially recommended method), this is a silent no-op: pip updates user/system site-packages, but the \�gent-reach\ executable points at the pipx venv - the version never changes and no error is shown.
Fix
Detect the install method and emit the matching update command:
Changes
Verification