Add intro + intial modeling attempt - #35
Merged
Merged
Conversation
Contributor
|
Thanks for this @AnoushkaGupta . If you add yourself to the https://github.com/PandoroML/LOAF/blob/main/docs/dev-log/.authors.yml file, the build of the docs should pass ;) |
Contributor
|
keenanjohnson
approved these changes
Aug 2, 2026
Contributor
|
Looks like a great start to me @AnoushkaGupta . I think it's ready to merge whenever you are. I left a few small comments here and three, but feel free to ignore them / address in the future if you'd like. |
keenanjohnson
approved these changes
Aug 2, 2026
Contributor
There was a problem hiding this comment.
Should we commit these training logs or add them to the gitignore?
Contributor
There was a problem hiding this comment.
Same question for the weights here. Is it good for us to add them to git?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.