Modern Kirigami UI Integration and KDE Plasma Support - #26
Conversation
…k system - Implement Kirigami detection and system path configuration in GUI entry point. - Redesign main UI using Kirigami ApplicationWindow, GlobalDrawer, and CardsListView. - Create a complete 'Standard' UI fallback for systems without Kirigami. - Adhere to KDE HIG 2024 and Kirigami design principles (Theme, Units). - Update documentation with system dependency installation instructions. - Ensure graceful degradation and cross-distro compatibility. Co-authored-by: Pakrohk <27810360+Pakrohk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Resolved QML namespace issues by using explicit 'Controls.' prefix for Qt Quick Controls. - Implemented 'Kirigami.PagePoolAction' for lazy loading of UI pages, improving performance. - Redesigned 'StandardMain.qml' with a sidebar navigation model for better parity with the Kirigami UI. - Switched to semantic font sizing using 'Kirigami.Theme' for better display scaling. - Integrated backend 'showToast' signal with Kirigami's 'showPassiveNotification'. - Removed redundant 'clip: true' and refined component layouts for KDE HIG 2024 compliance. - Ensured all 'Standard*' fallback pages are fully functional and namespace-correct. Co-authored-by: Pakrohk <27810360+Pakrohk@users.noreply.github.com>
- Implement Kirigami detection and system path configuration in GUI entry point. - Redesign main UI using Kirigami ApplicationWindow and GlobalDrawer (sidebar). - Adopt PlasmaComponents 3.0 for all modern QML components to ensure native styling. - Implement Kirigami.PagePool for efficient lazy loading of pages. - Modernize GameLibrary and Monitor pages using Kirigami.Card with banner layouts. - Adhere to KDE HIG 2024 by removing hardcoded colors/units and Material design overrides. - Fix Kirigami.PlaceholderMessage KF6 compatibility issues. - Create a complete 'Standard' UI fallback for non-KDE environments. - Update documentation with system dependency instructions for all major distros. Co-authored-by: Pakrohk <27810360+Pakrohk@users.noreply.github.com>
- Implement Kirigami detection and system path configuration in GUI entry point. - Redesign main UI using Kirigami ApplicationWindow and GlobalDrawer (sidebar). - Adopt PlasmaComponents 3.0 for all modern QML components to ensure native styling. - Implement Kirigami.PagePool for efficient lazy loading of pages. - Modernize GameLibrary and Monitor pages using Kirigami.Card with banner layouts. - Adhere to KDE HIG 2024 by removing hardcoded colors/units and Material design overrides. - Fix Kirigami.PlaceholderMessage and GlobalDrawer KF6 compatibility issues. - Create a complete 'Standard' UI fallback for non-KDE environments. - Update documentation with system dependency instructions for all major distros. Co-authored-by: Pakrohk <27810360+Pakrohk@users.noreply.github.com>
- Implement Kirigami detection and system path configuration in GUI entry point. - Redesign main UI using Kirigami ApplicationWindow and GlobalDrawer (sidebar). - Adopt PlasmaComponents 3.0 for all modern QML components to ensure native styling. - Implement Kirigami.PagePool for efficient lazy loading of pages. - Modernize GameLibrary and Monitor pages using Kirigami.Card with banner layouts. - Adhere to KDE HIG 2024 by removing hardcoded colors/units and Material design overrides. - Fix Kirigami.PlaceholderMessage and GlobalDrawer KF6 compatibility issues (Plasma 6.7+). - Create a complete 'Standard' UI fallback for non-KDE environments. - Update documentation with system dependency instructions for all major distros. Co-authored-by: Pakrohk <27810360+Pakrohk@users.noreply.github.com>
|
Dude, you're a god, I like what you're doing with this project. You can hit me up on X anytime if you need me to merge any commit to the main repo. I would love to see the finished project. Sorry i comment here, i don't know how to contact you since I don't use mastodon. Using yay or paru shows no package tho. I guess the package is not up yet so the install instructions don't work yet. |
I have a gmail and telegram account with the exact same github username so you can contact me The UI needs to be much more complete than it is. I'm a bit short on time these days, otherwise I would have completed QML myself by now. |
Thank you so much for the kind words! I'm glad you're enjoying the project. I've updated the README to include a note about the AUR package availability and added a 'Manual Installation' section so users can run it directly from source using |
- Added note about AUR package availability. - Added 'Manual Installation' section using `uv` for running from source. - Finalized UI modernization for Plasma 6.7 and Kirigami. Co-authored-by: Pakrohk <27810360+Pakrohk@users.noreply.github.com>
This PR significantly improves the KDE Plasma integration and modernizes the user interface of the
pnpproject.Key changes:
src/pnp/gui/__init__.pyto detect Kirigami in standard system QML paths and configure the environment (QT_PLUGIN_PATH, QT_QUICK_CONTROLS_STYLE) accordingly.GlobalDrawerfor navigation,CardsListViewfor controller and game management, andFormLayoutfor settings.Kirigami.Themefor colors andKirigami.Unitsfor spacing, providing a native look and feel on KDE Plasma.README.md,MIGRATION.md, andpyproject.tomlwith clear instructions on installing the required system dependencies (Kirigami, QQC2 Desktop Style) across major Linux distributions.These changes solve the issues of missing Kirigami detection, outdated layout patterns, and lack of system dependency documentation.
PR created automatically by Jules for task 17698351137612980705 started by @Pakrohk