Skip to content

[ThirdParty] Update gloo submodule to PFCCLab paddle branch - #79230

Merged
swgu98 merged 3 commits into
PaddlePaddle:developfrom
gouzil:codex/update-gloo-pfcc-paddle
Jun 4, 2026
Merged

swgu98 merged 3 commits into
PaddlePaddle:developfrom
gouzil:codex/update-gloo-pfcc-paddle

Conversation

@gouzil

@gouzil gouzil commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

PR Category

Environment Adaptation

PR Types

Devs

Description

  • 将 third_party/gloo 子模块地址切换为 https://github.com/PFCCLab/gloo.git 并设置分支为 paddle
  • gloo 支持 gcc15

相关链接:

是否引起精度变化

否

Copilot AI review requested due to automatic review settings June 2, 2026 17:07
@gouzil gouzil changed the title Update gloo submodule to PFCCLab paddle branch 【WIP】Update gloo submodule to PFCCLab paddle branch Jun 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Paddle’s third_party/gloo git submodule configuration to point at the PFCCLab fork/branch, presumably to pick up GCC15-related fixes from that fork.

Changes:

  • Switch third_party/gloo submodule URL to https://github.com/PFCCLab/gloo.git.
  • Add branch = paddle for the third_party/gloo submodule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .gitmodules Outdated
Comment on lines +15 to +16
url = https://github.com/PFCCLab/gloo.git
branch = paddle
Comment thread third_party/gloo

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 diff 为啥显示这么多?按我理解应该 diff 只有 1 行?

@gouzil gouzil Jun 3, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大概知道了,paddle 现在用的是 ziyoujiyi/gloo 自己打的 tag,版本是 0.0.3, 现在这个 pr 是基于 ziyoujiyi/gloo master 的

PaddlePaddle-bot

This comment was marked as outdated.

@paddle-bot paddle-bot Bot added the contributor External developers label Jun 2, 2026
@PaddlePaddle-bot

PaddlePaddle-bot commented Jun 3, 2026 •

Copy link
Copy Markdown

🤖 Paddle-CI-Agent | ci_status_monitor | 2026-06-04 12:19:23

CI报告基于以下代码生成(30分钟更新一次):
PR commit: d95d513 | Merge base: 4f3edc9 (branch: develop)


1 Required任务 : 78/83 通过

总执行(rerun次数) 总任务 ✅ 通过 ❌ 失败 ⏳ 运行中 ⏸️ 等待中 跳过
117(27) 90 83 0 0 0 7

无

2 失败详情

无

@gouzil gouzil changed the title 【WIP】Update gloo submodule to PFCCLab paddle branch [ThirdParty]Update gloo submodule to PFCCLab paddle branch Jun 3, 2026
@gouzil gouzil changed the title [ThirdParty]Update gloo submodule to PFCCLab paddle branch [ThirdParty] Update gloo submodule to PFCCLab paddle branch Jun 3, 2026
@gouzil
gouzil requested a review from SigureMo June 3, 2026 14:20

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@PaddlePaddle-bot PaddlePaddle-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Paddle-CI-Agent | pr_review | 2026-06-03 22:36:25

📋 Review 摘要

PR 概述:将 third_party/gloo 子模块从 ziyoujiyi/gloo 切换至 PFCCLab/gloo(paddle 分支),以支持 gcc15 编译。

变更范围:.gitmodules、third_party/gloo(submodule 指针)

影响面 Tag:ThirdParty Build

问题

未发现阻塞性问题。PR 规范问题在下面章节报,不要在这里重复。

历史 Findings 修复情况

Finding 问题 状态
F1 标题使用了非标准中文括号 【WIP】 ✅ 已修复

📝 PR 规范检查

当前标题 [ThirdParty] Update \gloo` submodule to PFCCLab paddle branch` 已修正为英文方括号 Tag 格式,WIP 标记已移除,基本符合规范。

Tag [ThirdParty] 不在 Paddle 官方 Category 或 Types 枚举中,建议使用官方枚举 Tag。

标题建议(可直接复制):

  • [Environment Adaptation] Update gloo submodule to PFCCLab/gloo for gcc15 support
PR 描述建议(点击展开,可直接复制)
### PR Category
Environment Adaptation

### PR Types
Devs

### Description

* 将 `third_party/gloo` 子模块地址切换为 `https://github.com/PFCCLab/gloo.git`(paddle 分支)
* gloo 新版本支持 gcc15 编译
* 已在 [Linux / Windows / Mac / XPU / DCU 等平台] 完成构建验证(请补充实际验证平台)

相关链接:
* PFCCLab/gloo#1

### 是否引起精度变化
否

总体评价

本 PR 变更量极小(2 文件,均为 submodule 指针/配置),逻辑清晰,目的明确。代码层面无阻塞性问题;建议将标题 Tag 替换为官方枚举值,并在描述中补充构建验证平台信息。

@swgu98
swgu98 merged commit 37f929b into PaddlePaddle:develop Jun 4, 2026
110 of 113 checks passed
@SigureMo
SigureMo deleted the codex/update-gloo-pfcc-paddle branch June 4, 2026 04:44
@paddle-bot

paddle-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers skip-ci: h-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants