Skip to content

Report wording: name the counted samples; meaning first in help texts - #56

Merged
ypriverol merged 1 commit into
fix/lod-analysis-controlsfrom
fix/report-wording-48
Oct 8, 2026
Merged

ypriverol merged 1 commit into
fix/lod-analysis-controlsfrom
fix/report-wording-48

Conversation

@ypriverol

Copy link
Copy Markdown
Contributor

Items 1–3 of #48. Stacked on #55 (stack: #52 → #53 → #55 → this).

  1. Summary rows name what is counted. They now read "Samples with possible hemolysis (indicator outliers)" and "Samples with possible platelet activation (indicator outliers)". "0 / 20" was the number of flagged study samples over the number of study samples. For the same reason, "Protein-predicted sex (F / M)" becomes "Samples by protein-predicted sex (F / M)".
  2. MPI help text: what the value means ("Higher is more consistent… not an acceptance threshold") now comes first, followed by the linear-scale and group-aware details.
  3. Rank concordance help text: the scale-independence sentence moves to the end.

Text only. The tests are updated, and a new test checks the order of the help texts. With CI's versions: 203 passed; ruff and mypy are clean.

Item 4 is answered on #48 (no code change). Item 5 is in the next PR of the stack.

Issue #48 items 1-3.
- summary rows say what is counted: "Samples with possible hemolysis
  (indicator outliers)", "Samples with possible platelet activation
  (indicator outliers)", "Samples by protein-predicted sex (F / M)"
- MPI help: what the value means comes before the linear-scale and
  group-aware details
- rank concordance help: the scale-independence sentence comes last
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 570a0a9f-d89b-40e4-89cf-6b3de2fca4c4
📥 Commits

Reviewing files that changed from the base of the PR and between 6b4c9f9 and 4ce00e0.

📒 Files selected for processing (2)
  • src/pyprideap/viz/qc/report.py
  • tests/test_qc_pipeline.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ypriverol
ypriverol added this pull request to stack #54 October 8, 2026 14:44
@ypriverol
ypriverol merged commit 06f715d into main Oct 8, 2026
7 checks passed
@ypriverol
ypriverol deleted the fix/report-wording-48 branch October 8, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant