Skip to content

Squiz/SwitchDeclaration: remove duplicate strtoupper($type) calls - #1490

Open
ntdiary wants to merge 1 commit into
PHPCSStandards:4.xfrom
ntdiary:issue-1472-squiz-error-message-followup
Open

Squiz/SwitchDeclaration: remove duplicate strtoupper($type) calls#1490
ntdiary wants to merge 1 commit into
PHPCSStandards:4.xfrom
ntdiary:issue-1472-squiz-error-message-followup

Conversation

@ntdiary

@ntdiary ntdiary commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

Cache strtoupper($type) in $typeUc instead of calling it repeatedly.

Suggested changelog entry

N/A

Related issues/external references

Related #1472

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • I have opened a sister-PR in the documentation repository to update the Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant