Repository navigation
Conversation
Let run_alignment_test.sh own environment setup and propagate setup failures. Signed-off-by: Zhan Rongrui <me@zrr.dev>
Signed-off-by: zrr1999 <2742392377@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The workflow calls setup_venvs.sh before run_alignment_test.sh, which already calls it. This installs the environment twice and starts a second attempt after the first setup fails. Remove the redundant workflow call so the test entrypoint owns setup; its existing
set -euo pipefailand the workflow exit-status check propagate installation failures.Validation: after a normal merge of current PFCCLab
main, the PR diff remains one removed workflow command. Repository pre-commit checks andtools/autoformat.shin check mode passed. The actual workflow shell tail and test entrypoint passed four isolated command replays: success, setup failure, model failure, and comparison failure. Setup runs exactly once; its failure starts no models, and all failure paths return nonzero. The unchanged upstream baseline reproduces duplicate setup. Real GPU alignment passed in the current CI run: MinimaxV2.5 EP2, two ranks and ten training steps, with identical per-token and final-loss MD5 values for every rank and step.This removes duplicate setup invocations; it does not change the package manager's own download retries or fix network connection resets.
Issue tracking
For PRs from open-source community contributors:
Related failure: https://github.com/PFCCLab/Megatron-LM/actions/runs/34825280415/job/103915866438
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.