Three small fixes: neutral example ticker, rf units bug, trim the rail - #22
Merged
Merged
Conversation
GusFurtado
force-pushed
the
colorblind-safe-palette
branch
from
September 12, 2026 00:51
6b69264 to
a7065d9
Compare
- Placeholder example ticker changed from TSLA to SPY (an index ETF,
not tied to any individual) — a more politically neutral example.
- Real bug: toggling Monthly/Annualized never updated the risk-free
field's label or value. Both were only ever refreshed from the rf
slider's own `input` handler, so they went stale the moment you hit
the units button without also touching the slider. Added
renderRfControl() to the main render() loop, where every other
unit-dependent display already lives, and dropped the now-redundant
duplicate update from the slider's own handler.
- Removed the rail's section TOC (5-item anchor list) and the mascot
tip card below the Run button, per feedback that both were low value
("kinda useless" / "gibberish"). The rail now ends at Run analysis.
Report sections keep their ids (#frontier, #allocation, etc.) even
without the nav pointing at them; the mascot image itself is still
used elsewhere (running overlay, saved-runs empty state, get-started
card) so only the now-dead .mw-toc/.mw-rail-note CSS was removed
along with the markup.
Verified with headless Chromium: placeholder reads "e.g. SPY"; toggling
units updates both #mwrf-label and #mwrf-display correctly in both
directions; the TOC and rail note are gone from the DOM.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
GusFurtado
force-pushed
the
rail-cleanup-and-fixes
branch
from
September 12, 2026 00:52
40caf31 to
7eb210d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Three items from feedback on the live preview. Stacked on #21.
What changed
inputhandler, so they went stale the moment you hit the units button without also touching the slider. Moved the update into the mainrender()loop (renderRfControl()), where every other unit-dependent display already lives.ids even without a nav pointing at them; the mascot image is still used elsewhere (running overlay, saved-runs empty state, get-started card), so only the now-dead.mw-toc/.mw-rail-noteCSS came out along with the markup.Verification
Headless Chromium: placeholder reads "e.g. SPY"; toggling units updates both the rf label and its displayed value correctly in both directions; the TOC and rail note are confirmed gone from the DOM.
🤖 Generated with Claude Code